Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ramanaidu.naladala@intel.com,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t v2 2/5] tests/intel/kms_psr*: Add psr_sink_error_check to PSR tests
Date: Wed, 11 Sep 2024 08:49:55 +0300	[thread overview]
Message-ID: <20240911054958.1023925-3-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240911054958.1023925-1-jouni.hogander@intel.com>

Currently we are ignoring possible errors detected by the sink in our
PSR testcases. Fix this by add psr_sink_error_check to each of them.

v2: split kms_fbt and kms_pm_dc to separate patches

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 tests/intel/kms_psr.c             | 2 ++
 tests/intel/kms_psr2_sf.c         | 2 ++
 tests/intel/kms_psr2_su.c         | 2 ++
 tests/intel/kms_psr_stress_test.c | 1 +
 4 files changed, 7 insertions(+)

diff --git a/tests/intel/kms_psr.c b/tests/intel/kms_psr.c
index cf0ce4bb8..2badeeddd 100644
--- a/tests/intel/kms_psr.c
+++ b/tests/intel/kms_psr.c
@@ -650,6 +650,8 @@ static void test_cleanup(data_t *data)
 {
 	igt_plane_t *primary;
 
+	psr_sink_error_check(data->debugfs_fd, data->op_psr_mode, data->output);
+
 	igt_output_override_mode(data->output, NULL);
 
 	primary = igt_output_get_plane_type(data->output,
diff --git a/tests/intel/kms_psr2_sf.c b/tests/intel/kms_psr2_sf.c
index 03ff1cddb..a9be1a1ec 100644
--- a/tests/intel/kms_psr2_sf.c
+++ b/tests/intel/kms_psr2_sf.c
@@ -972,6 +972,8 @@ static void run(data_t *data)
 	default:
 		igt_assert(false);
 	}
+
+	psr_sink_error_check(data->debugfs_fd, data->psr_mode, data->output);
 }
 
 static void cleanup(data_t *data)
diff --git a/tests/intel/kms_psr2_su.c b/tests/intel/kms_psr2_su.c
index 437ee36f6..0099daf1d 100644
--- a/tests/intel/kms_psr2_su.c
+++ b/tests/intel/kms_psr2_su.c
@@ -273,6 +273,8 @@ static void run(data_t *data, igt_output_t *output)
 
 	igt_assert_f(result,
 		     "No matching selective update blocks read from debugfs\n");
+
+	psr_sink_error_check(data->debugfs_fd, PSR_MODE_2, output);
 }
 
 static void cleanup(data_t *data, igt_output_t *output)
diff --git a/tests/intel/kms_psr_stress_test.c b/tests/intel/kms_psr_stress_test.c
index d6e2340b8..73a6eb56d 100644
--- a/tests/intel/kms_psr_stress_test.c
+++ b/tests/intel/kms_psr_stress_test.c
@@ -344,6 +344,7 @@ static void run(data_t *data)
 
 	/* Check if after all this stress the PSR is still in the same state */
 	igt_assert(psr_get_mode(data->debugfs_fd, NULL) == data->initial_state);
+	psr_sink_error_check(data->debugfs_fd, data->initial_state, data->output);
 }
 
 igt_main
-- 
2.34.1


  parent reply	other threads:[~2024-09-11  5:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  5:49 [PATCH i-g-t v2 0/5] PSR testing improvement by checking sink status Jouni Högander
2024-09-11  5:49 ` [PATCH i-g-t v2 1/5] lib/igt_psr: Add mechanism to check sink status as well Jouni Högander
2024-09-11  5:49 ` Jouni Högander [this message]
2024-09-11 10:53   ` [PATCH i-g-t v2 2/5] tests/intel/kms_psr*: Add psr_sink_error_check to PSR tests Thasleem, Mohammed
2024-09-11  5:49 ` [PATCH i-g-t v2 3/5] tests/intel/kms_fbt: " Jouni Högander
2024-09-11 11:34   ` Thasleem, Mohammed
2024-09-11  5:49 ` [PATCH i-g-t v2 4/5] test/intel/kms_pm_dc: " Jouni Högander
2024-09-11  9:54   ` Thasleem, Mohammed
2024-09-11  5:49 ` [PATCH i-g-t v2 5/5] tests/intel/kms_dirtyfb: Check features after rendering Jouni Högander
2024-09-12  3:34 ` ✓ CI.xeBAT: success for PSR testing improvement by checking sink status Patchwork
2024-09-12  3:46 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-12  8:12 ` ✓ CI.xeFULL: " Patchwork
2024-09-12 22:50 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-17 11:38   ` Hogander, Jouni
2024-09-17 11:59 ` [PATCH i-g-t v2 0/5] " Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240911054958.1023925-3-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ramanaidu.naladala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox