From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ramanaidu.naladala@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t v2 5/5] tests/intel/kms_dirtyfb: Check features after rendering
Date: Wed, 11 Sep 2024 08:49:58 +0300 [thread overview]
Message-ID: <20240911054958.1023925-6-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240911054958.1023925-1-jouni.hogander@intel.com>
Check each feature after rendering and flush. Also add new check for
possible PSR errors.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
---
tests/intel/kms_dirtyfb.c | 33 +++++++++++++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 75047ec63..35df9be3b 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -145,7 +145,7 @@ static void enable_feature(data_t *data)
}
}
-static void check_feature(data_t *data)
+static void check_feature_enabled(data_t *data)
{
switch (data->feature) {
case FEATURE_NONE:
@@ -171,6 +171,33 @@ static void check_feature(data_t *data)
}
}
+static void check_feature(data_t *data)
+{
+ switch (data->feature) {
+ case FEATURE_NONE:
+ break;
+ case FEATURE_FBC:
+ igt_assert_f(intel_fbc_wait_until_enabled(data->drm_fd,
+ data->pipe),
+ "FBC disabled\n");
+ /* TODO: Add compression check here */
+ break;
+ case FEATURE_PSR:
+ igt_assert_f(psr_wait_entry(data->debugfs_fd, PSR_MODE_1, data->output),
+ "No PSR entry\n");
+ psr_sink_error_check(data->debugfs_fd, PSR_MODE_1, data->output);
+ break;
+ case FEATURE_DRRS:
+ igt_assert_f(!intel_is_drrs_inactive(data->drm_fd, data->pipe),
+ "DRRS INACTIVE\n");
+ break;
+ case FEATURE_DEFAULT:
+ break;
+ default:
+ igt_assert(false);
+ }
+}
+
static void disable_features(data_t *data)
{
intel_fbc_disable(data->drm_fd);
@@ -232,7 +259,7 @@ static void prepare(data_t *data)
igt_display_commit2(&data->display, COMMIT_ATOMIC);
- check_feature(data);
+ check_feature_enabled(data);
}
static void cleanup(data_t *data)
@@ -298,6 +325,8 @@ static void run_test(data_t *data)
igt_pipe_crc_collect_crc(data->pipe_crc, &crc);
igt_assert_crc_equal(&crc, &data->ref_crc);
+ check_feature(data);
+
igt_spin_free(data->drm_fd, spin);
intel_bb_destroy(ibb);
intel_buf_destroy(src);
--
2.34.1
next prev parent reply other threads:[~2024-09-11 5:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 5:49 [PATCH i-g-t v2 0/5] PSR testing improvement by checking sink status Jouni Högander
2024-09-11 5:49 ` [PATCH i-g-t v2 1/5] lib/igt_psr: Add mechanism to check sink status as well Jouni Högander
2024-09-11 5:49 ` [PATCH i-g-t v2 2/5] tests/intel/kms_psr*: Add psr_sink_error_check to PSR tests Jouni Högander
2024-09-11 10:53 ` Thasleem, Mohammed
2024-09-11 5:49 ` [PATCH i-g-t v2 3/5] tests/intel/kms_fbt: " Jouni Högander
2024-09-11 11:34 ` Thasleem, Mohammed
2024-09-11 5:49 ` [PATCH i-g-t v2 4/5] test/intel/kms_pm_dc: " Jouni Högander
2024-09-11 9:54 ` Thasleem, Mohammed
2024-09-11 5:49 ` Jouni Högander [this message]
2024-09-12 3:34 ` ✓ CI.xeBAT: success for PSR testing improvement by checking sink status Patchwork
2024-09-12 3:46 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-12 8:12 ` ✓ CI.xeFULL: " Patchwork
2024-09-12 22:50 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-17 11:38 ` Hogander, Jouni
2024-09-17 11:59 ` [PATCH i-g-t v2 0/5] " Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911054958.1023925-6-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox