From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Alex Hung <alex.hung@amd.com>, <quic_abhinavk@quicinc.com>,
<igt-dev@lists.freedesktop.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Esha Bharadwaj <quic_ebharadw@quicinc.com>
Subject: [PATCH i-g-t v4 0/4] tests/kms_writeback: Add clone mode subtest
Date: Wed, 25 Sep 2024 13:37:17 -0700 [thread overview]
Message-ID: <20240925-igt-cwb-v4-0-e516cd1e888e@quicinc.com> (raw)
Add a subtest that will iterate through all pairs of
non-writeback and writeback cloned outputs and dump the writeback
framebuffer for each pair.
This series includes:
- Fixes for properly cleaning up the kms_writeback state
- Adjust the duplicate pipe check in igt_display_refresh() to allow for
combinations of valid clones
- Moving the writeback dump to its own subtest
- Adding a subtest to dump all writeback+non-writeback cloned pairs
This series depends on this DRM framework change [1] to avoid issues
where modeset isn't happening when the writeback and primary display
outputs have the same mode.
[1] https://patchwork.freedesktop.org/series/138284/
To dump the clone mode buffer, run the following command:
IGT_FRAME_DUMP_PATH=<dump path> FRAME_PNG_FILE_NAME=<file name> \
./build/tests/kms_writeback [--run-subtest dump-valid-clones] -d
This will output a file named <file name>-encoder<writeback encoder
id>-encoder<primary display encoder id>
---
Changes in v4:
- Fix compiler issues with igt_output_clone_valid()
- Add a NULL commit to clean up each non-writeback output
- Link to v3: https://lore.kernel.org/r/20240919-igt-cwb-v3-0-2bb3161f1f96@quicinc.com
Changes in v3:
- Dropped change to force a modeset after igt_display_require()
- Fixed incorrect author name
- Grab the primary display mode as part of the clone mode subtest
(instead of requiring user to specify the mode)
- Link to v2: https://lore.kernel.org/r/20240828-igt-cwb-v2-0-7b255c730c55@quicinc.com
Changes in v2:
- Corrected author email
- Link to v1: https://lore.kernel.org/r/20240828-igt-cwb-v1-0-48aee421fc97@quicinc.com
---
Esha Bharadwaj (3):
lib/igt_kms: Add helper to get encoder index
lib/igt_kms: loosen duplicate check in igt_display_refresh
tests/kms_writeback: Add dump for valid clone mode
Jessica Zhang (1):
tests/kms_writeback: clear writeback properties in teardown path
lib/igt_kms.c | 57 +++++++++++++++++++++++-----
lib/igt_kms.h | 2 +
tests/kms_setmode.c | 14 +------
tests/kms_writeback.c | 100 +++++++++++++++++++++++++++++++++++++++++++-------
4 files changed, 139 insertions(+), 34 deletions(-)
---
base-commit: 52b3f11e13a18b5dc17d1ac647ac380b9b1ea764
change-id: 20240827-igt-cwb-23fd81d3a7a4
Best regards,
--
Jessica Zhang <quic_jesszhan@quicinc.com>
next reply other threads:[~2024-09-25 20:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 20:37 Jessica Zhang [this message]
2024-09-25 20:37 ` [PATCH i-g-t v4 1/4] tests/kms_writeback: clear writeback properties in teardown path Jessica Zhang
2024-09-25 20:46 ` Abhinav Kumar
2024-10-14 13:52 ` Kamil Konieczny
2024-10-14 19:05 ` Abhinav Kumar
2024-09-25 20:37 ` [PATCH i-g-t v4 2/4] lib/igt_kms: Add helper to get encoder index Jessica Zhang
2024-09-25 21:10 ` Abhinav Kumar
2024-09-25 20:37 ` [PATCH i-g-t v4 3/4] lib/igt_kms: loosen duplicate check in igt_display_refresh Jessica Zhang
2024-09-25 21:00 ` Abhinav Kumar
2024-09-25 20:37 ` [PATCH i-g-t v4 4/4] tests/kms_writeback: Add dump for valid clone mode Jessica Zhang
2024-09-25 21:55 ` Abhinav Kumar
2024-10-14 12:32 ` Juha-Pekka Heikkila
2024-09-26 9:20 ` ✗ Fi.CI.BAT: failure for tests/kms_writeback: Add clone mode subtest (rev4) Patchwork
2024-09-26 9:39 ` ✗ CI.xeBAT: " Patchwork
2024-09-27 0:56 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925-igt-cwb-v4-0-e516cd1e888e@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=adrinael@adrinael.net \
--cc=alex.hung@amd.com \
--cc=arek@hiler.eu \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_ebharadw@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox