From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Jessica Zhang <quic_jesszhan@quicinc.com>,
Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Alex Hung <alex.hung@amd.com>, <igt-dev@lists.freedesktop.org>,
"Esha Bharadwaj" <quic_ebharadw@quicinc.com>
Subject: Re: [PATCH i-g-t v4 2/4] lib/igt_kms: Add helper to get encoder index
Date: Wed, 25 Sep 2024 14:10:00 -0700 [thread overview]
Message-ID: <be7bb479-bce5-4ce9-9e62-30ef4ba0c631@quicinc.com> (raw)
In-Reply-To: <20240925-igt-cwb-v4-2-e516cd1e888e@quicinc.com>
On 9/25/2024 1:37 PM, Jessica Zhang wrote:
> From: Esha Bharadwaj <quic_ebharadw@quicinc.com>
>
> Move the get_encoder_idx() helper within the kms_setmode test to
> lib/igt_kms
>
> Signed-off-by: Esha Bharadwaj <quic_ebharadw@quicinc.com>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> lib/igt_kms.c | 15 +++++++++++++++
> lib/igt_kms.h | 1 +
> tests/kms_setmode.c | 14 ++------------
> 3 files changed, 18 insertions(+), 12 deletions(-)
>
Change LGTM, but will ack this once comments on (3) are addressed.
next prev parent reply other threads:[~2024-09-25 21:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 20:37 [PATCH i-g-t v4 0/4] tests/kms_writeback: Add clone mode subtest Jessica Zhang
2024-09-25 20:37 ` [PATCH i-g-t v4 1/4] tests/kms_writeback: clear writeback properties in teardown path Jessica Zhang
2024-09-25 20:46 ` Abhinav Kumar
2024-10-14 13:52 ` Kamil Konieczny
2024-10-14 19:05 ` Abhinav Kumar
2024-09-25 20:37 ` [PATCH i-g-t v4 2/4] lib/igt_kms: Add helper to get encoder index Jessica Zhang
2024-09-25 21:10 ` Abhinav Kumar [this message]
2024-09-25 20:37 ` [PATCH i-g-t v4 3/4] lib/igt_kms: loosen duplicate check in igt_display_refresh Jessica Zhang
2024-09-25 21:00 ` Abhinav Kumar
2024-09-25 20:37 ` [PATCH i-g-t v4 4/4] tests/kms_writeback: Add dump for valid clone mode Jessica Zhang
2024-09-25 21:55 ` Abhinav Kumar
2024-10-14 12:32 ` Juha-Pekka Heikkila
2024-09-26 9:20 ` ✗ Fi.CI.BAT: failure for tests/kms_writeback: Add clone mode subtest (rev4) Patchwork
2024-09-26 9:39 ` ✗ CI.xeBAT: " Patchwork
2024-09-27 0:56 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be7bb479-bce5-4ce9-9e62-30ef4ba0c631@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=adrinael@adrinael.net \
--cc=alex.hung@amd.com \
--cc=arek@hiler.eu \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=quic_ebharadw@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox