From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ramanaidu.naladala@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t 2/2] lib/igt_psr: Assert on sink/source state mismatch
Date: Thu, 26 Sep 2024 10:05:17 +0300 [thread overview]
Message-ID: <20240926070517.1326936-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240926070517.1326936-1-jouni.hogander@intel.com>
Assert if sink state is not PSR active while source state is PSR
active. This makes it easier to identify failure due to sink/source
mismatch.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
lib/igt_psr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index 963385967..0eb002633 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -117,8 +117,10 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode, igt_output_t *o
active = strstr(buf, state);
env = getenv("IGT_PANEL_REPLAY_IGNORE_SINK_STATUS");
- if (active && output && (!env || !atoi(env)))
+ if (active && output && (!env || !atoi(env))) {
active = psr_active_sink_check(debugfs_fd, output);
+ igt_assert_f(active, "PSR sink/source state mismatch\n");
+ }
return active;
}
--
2.34.1
next prev parent reply other threads:[~2024-09-26 7:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 7:05 [PATCH i-g-t 1/2] lib/igt_psr: Allow testing without checking sink status Jouni Högander
2024-09-26 7:05 ` Jouni Högander [this message]
2024-10-01 6:20 ` [PATCH i-g-t 2/2] lib/igt_psr: Assert on sink/source state mismatch B, Jeevan
2024-10-02 8:32 ` Hogander, Jouni
2024-09-26 10:50 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_psr: Allow testing without checking sink status Patchwork
2024-09-26 11:01 ` ✓ CI.xeBAT: " Patchwork
2024-09-26 13:34 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-27 3:42 ` ✗ CI.xeFULL: " Patchwork
2024-09-27 6:27 ` [PATCH i-g-t 1/2] " B, Jeevan
2024-09-27 6:38 ` B, Jeevan
2024-10-01 6:20 ` B, Jeevan
2024-09-30 19:20 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_psr: Allow testing without checking sink status (rev2) Patchwork
2024-09-30 19:29 ` ✓ CI.xeBAT: " Patchwork
2024-10-01 1:56 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-02 7:16 ` Hogander, Jouni
2024-10-01 5:26 ` ✗ Fi.CI.IGT: " Patchwork
2024-10-02 7:46 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926070517.1326936-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox