Re: [PATCH i-g-t 2/2] lib/igt_psr: Assert on sink/source state mismatch

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2024-10-01 at 06:20 +0000, B, Jeevan wrote:
> LGTM 
> 
> Reviewed-by: Jeevan B <jeevan.b@intel.com>

Thank you Jeevan for your review. These are now pushed to master.

BR,

Jouni Högander

> 
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> > Jouni
> > Högander
> > Sent: Thursday, September 26, 2024 12:35 PM
> > To: igt-dev@lists.freedesktop.org
> > Cc: Naladala, Ramanaidu <ramanaidu.naladala@intel.com>; Hogander,
> > Jouni
> > <jouni.hogander@intel.com>
> > Subject: [PATCH i-g-t 2/2] lib/igt_psr: Assert on sink/source state
> > mismatch
> > 
> > Assert if sink state is not PSR active while source state is PSR
> > active. This makes it
> > easier to identify failure due to sink/source mismatch.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >  lib/igt_psr.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/igt_psr.c b/lib/igt_psr.c index
> > 963385967..0eb002633 100644
> > --- a/lib/igt_psr.c
> > +++ b/lib/igt_psr.c
> > @@ -117,8 +117,10 @@ static bool psr_active_check(int debugfs_fd,
> > enum
> > psr_mode mode, igt_output_t *o
> >         active = strstr(buf, state);
> > 
> >         env = getenv("IGT_PANEL_REPLAY_IGNORE_SINK_STATUS");
> > -       if (active && output && (!env || !atoi(env)))
> > +       if (active && output && (!env || !atoi(env))) {
> >                 active = psr_active_sink_check(debugfs_fd, output);
> > +               igt_assert_f(active, "PSR sink/source state
> > mismatch\n");
> > +       }
> > 
> >         return active;
> >  }
> > --
> > 2.34.1
>