From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t v2] tests/intel/kms_fbcon_fbt: Use linear instead of x tiled
Date: Wed, 23 Oct 2024 09:07:40 +0300 [thread overview]
Message-ID: <20241023060740.2573443-1-jouni.hogander@intel.com> (raw)
PTL doesn't support x tiled format and older platforms (display version <
9) do not have FBC support for linear. There is no specific reason to use x
tiled format in this testcase: switch to linear format except on older
platforms.
v2: use x tiled for display version < 9
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
tests/intel/kms_fbcon_fbt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
index 6d134ea62..ab4819d23 100644
--- a/tests/intel/kms_fbcon_fbt.c
+++ b/tests/intel/kms_fbcon_fbt.c
@@ -221,7 +221,9 @@ static void set_mode_for_one_screen(struct drm_info *drm,
buffer_id = igt_create_fb(drm->fd, mode->hdisplay, mode->vdisplay,
DRM_FORMAT_XRGB8888,
- I915_FORMAT_MOD_X_TILED, &drm->fb);
+ intel_display_ver(intel_get_drm_devid(drm->fd)) < 9 ?
+ I915_FORMAT_MOD_X_TILED : DRM_FORMAT_MOD_LINEAR,
+ &drm->fb);
igt_draw_fill_fb(drm->fd, &drm->fb, 0xFF);
igt_info("Setting %dx%d mode for %s connector\n",
--
2.34.1
next reply other threads:[~2024-10-23 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 6:07 Jouni Högander [this message]
2024-10-23 7:59 ` ✓ Fi.CI.BAT: success for tests/intel/kms_fbcon_fbt: Use linear instead of x tiled (rev2) Patchwork
2024-10-23 8:07 ` ✓ CI.xeBAT: " Patchwork
2024-10-23 11:33 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-25 11:45 ` Hogander, Jouni
2024-10-23 12:03 ` ✗ Fi.CI.IGT: " Patchwork
2024-10-25 11:45 ` Hogander, Jouni
2024-10-25 11:38 ` [PATCH i-g-t v2] tests/intel/kms_fbcon_fbt: Use linear instead of x tiled Juha-Pekka Heikkila
2024-10-25 11:53 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023060740.2573443-1-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox