Re: [PATCH i-g-t v2] tests/intel/kms_fbcon_fbt: Use linear instead of x tiled

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Fri, 2024-10-25 at 14:38 +0300, Juha-Pekka Heikkila wrote:
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Thank you Juha-Pekka for checking my patch. This is now pushed to
master.

BR,

Jouni Högander

> 
> On 23.10.2024 9.07, Jouni Högander wrote:
> > PTL doesn't support x tiled format and older platforms (display
> > version <
> > 9) do not have FBC support for linear. There is no specific reason
> > to use x
> > tiled format in this testcase: switch to linear format except on
> > older
> > platforms.
> > 
> > v2: use x tiled for display version < 9
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >   tests/intel/kms_fbcon_fbt.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/intel/kms_fbcon_fbt.c
> > b/tests/intel/kms_fbcon_fbt.c
> > index 6d134ea62..ab4819d23 100644
> > --- a/tests/intel/kms_fbcon_fbt.c
> > +++ b/tests/intel/kms_fbcon_fbt.c
> > @@ -221,7 +221,9 @@ static void set_mode_for_one_screen(struct
> > drm_info *drm,
> >   
> >         buffer_id = igt_create_fb(drm->fd, mode->hdisplay, mode-
> > >vdisplay,
> >                                   DRM_FORMAT_XRGB8888,
> > -                                 I915_FORMAT_MOD_X_TILED, &drm-
> > >fb);
> > +                                
> > intel_display_ver(intel_get_drm_devid(drm->fd)) < 9 ?
> > +                                 I915_FORMAT_MOD_X_TILED :
> > DRM_FORMAT_MOD_LINEAR,
> > +                                 &drm->fb);
> >         igt_draw_fill_fb(drm->fd, &drm->fb, 0xFF);
> >   
> >         igt_info("Setting %dx%d mode for %s connector\n",
>