Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ashutosh.dixit@intel.com, sai.teja.pottumuttu@intel.com
Subject: [PATCH i-g-t 2/2] tests/intel/xe_oa: Replace hardcoded OA buffer size assumptions
Date: Mon, 18 Nov 2024 12:02:23 +0530	[thread overview]
Message-ID: <20241118063223.3974722-3-sai.teja.pottumuttu@intel.com> (raw)
In-Reply-To: <20241118063223.3974722-1-sai.teja.pottumuttu@intel.com>

A few xe_oa tests assumed that the default OA buffer size is 16MB
and had calculations around it. These would fail if the default
buffer size is changed on the kernel side.

Replace such assumptions with the OA buffer size we get from
DRM_XE_OBSERVATION_IOCTL_INFO ioctl

Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
---
 tests/intel/xe_oa.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 4e4d0fabc..3b65212ae 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -2389,7 +2389,7 @@ test_buffer_fill(const struct drm_xe_engine_class_instance *hwe)
 		.properties_ptr = to_user_pointer(properties),
 	};
 	size_t report_size = get_oa_format(fmt).size;
-	int buf_size = 65536 * report_size;
+	int buf_size = oa_buffer_size;
 	uint8_t *buf = malloc(buf_size);
 	int len;
 	size_t oa_buf_size = oa_buffer_size;
@@ -2533,7 +2533,7 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe)
 		.num_properties = ARRAY_SIZE(properties) / 2,
 		.properties_ptr = to_user_pointer(properties),
 	};
-	uint32_t buf_size = 3 * 65536 * report_size;
+	uint32_t buf_size = 3 * oa_buffer_size;
 	uint8_t *buf = malloc(buf_size);
 	uint32_t total_len = 0;
 	const uint32_t *last_report;
@@ -2615,7 +2615,7 @@ test_enable_disable(const struct drm_xe_engine_class_instance *hwe)
 		.properties_ptr = to_user_pointer(properties),
 	};
 	size_t report_size = get_oa_format(fmt).size;
-	int buf_size = 65536 * report_size;
+	int buf_size = oa_buffer_size;
 	uint8_t *buf = malloc(buf_size);
 	size_t oa_buf_size = oa_buffer_size;
 	int n_full_oa_reports = oa_buf_size / report_size;
-- 
2.34.1


  parent reply	other threads:[~2024-11-18  6:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18  6:32 [PATCH i-g-t 0/2] tests/intel/xe_oa: Refactors related to OA buffer size Sai Teja Pottumuttu
2024-11-18  6:32 ` [PATCH i-g-t 1/2] tests/intel/xe_oa: Fetch OA buffer size from observation IOCTL Sai Teja Pottumuttu
2024-11-18 19:51   ` Dixit, Ashutosh
2024-11-19  6:19     ` Pottumuttu, Sai Teja
2024-11-18 20:03   ` Dixit, Ashutosh
2024-11-18  6:32 ` Sai Teja Pottumuttu [this message]
2024-11-18 20:24   ` [PATCH i-g-t 2/2] tests/intel/xe_oa: Replace hardcoded OA buffer size assumptions Dixit, Ashutosh
2024-11-19  7:01     ` Pottumuttu, Sai Teja
2024-11-19  7:21       ` Dixit, Ashutosh
2024-11-19  7:28         ` Pottumuttu, Sai Teja
2024-11-18  7:10 ` ✗ CI.xeBAT: failure for tests/intel/xe_oa: Refactors related to OA buffer size Patchwork
2024-11-18 11:48 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-18 12:42 ` ✗ CI.xeFULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241118063223.3974722-3-sai.teja.pottumuttu@intel.com \
    --to=sai.teja.pottumuttu@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox