From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 1/2] tests/intel/xe_oa: Fetch OA buffer size from observation IOCTL
Date: Mon, 18 Nov 2024 12:03:20 -0800 [thread overview]
Message-ID: <85wmh0wbqv.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20241118063223.3974722-2-sai.teja.pottumuttu@intel.com>
On Sun, 17 Nov 2024 22:32:22 -0800, Sai Teja Pottumuttu wrote:
>
> @@ -2367,7 +2392,7 @@ test_buffer_fill(const struct drm_xe_engine_class_instance *hwe)
> int buf_size = 65536 * report_size;
> uint8_t *buf = malloc(buf_size);
> int len;
> - size_t oa_buf_size = MAX_OA_BUF_SIZE;
> + size_t oa_buf_size = oa_buffer_size;
> int n_full_oa_reports = oa_buf_size / report_size;
> uint64_t fill_duration = n_full_oa_reports * oa_period;
> uint32_t *last_periodic_report = malloc(report_size);
> @@ -2592,7 +2617,7 @@ test_enable_disable(const struct drm_xe_engine_class_instance *hwe)
> size_t report_size = get_oa_format(fmt).size;
> int buf_size = 65536 * report_size;
> uint8_t *buf = malloc(buf_size);
> - size_t oa_buf_size = MAX_OA_BUF_SIZE;
> + size_t oa_buf_size = oa_buffer_size;
> int n_full_oa_reports = oa_buf_size / report_size;
> uint64_t fill_duration = n_full_oa_reports * oa_period;
> uint32_t *last_periodic_report = malloc(report_size);
Maybe get rid of these two oa_buf_size local variables too, directly use
default_oa_buffer_size.
next prev parent reply other threads:[~2024-11-18 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 6:32 [PATCH i-g-t 0/2] tests/intel/xe_oa: Refactors related to OA buffer size Sai Teja Pottumuttu
2024-11-18 6:32 ` [PATCH i-g-t 1/2] tests/intel/xe_oa: Fetch OA buffer size from observation IOCTL Sai Teja Pottumuttu
2024-11-18 19:51 ` Dixit, Ashutosh
2024-11-19 6:19 ` Pottumuttu, Sai Teja
2024-11-18 20:03 ` Dixit, Ashutosh [this message]
2024-11-18 6:32 ` [PATCH i-g-t 2/2] tests/intel/xe_oa: Replace hardcoded OA buffer size assumptions Sai Teja Pottumuttu
2024-11-18 20:24 ` Dixit, Ashutosh
2024-11-19 7:01 ` Pottumuttu, Sai Teja
2024-11-19 7:21 ` Dixit, Ashutosh
2024-11-19 7:28 ` Pottumuttu, Sai Teja
2024-11-18 7:10 ` ✗ CI.xeBAT: failure for tests/intel/xe_oa: Refactors related to OA buffer size Patchwork
2024-11-18 11:48 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-18 12:42 ` ✗ CI.xeFULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85wmh0wbqv.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=sai.teja.pottumuttu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox