Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 i-g-t 0/3] Improvements for xe_sriov_flr test and xe_mmio lib
@ 2024-11-20 17:37 Marcin Bernatowicz
  2024-11-20 17:37 ` [PATCH v2 i-g-t 1/3] lib/xe/xe_mmio: Replace open-coded init/cleanup with existing functions Marcin Bernatowicz
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Marcin Bernatowicz @ 2024-11-20 17:37 UTC (permalink / raw)
  To: igt-dev
  Cc: kamil.konieczny, adam.miszczak, jakub1.kolakowski, lukasz.laguna,
	michal.wajdeczko, michal.winiarski, narasimha.c.v,
	piotr.piorkowski, satyanarayana.k.v.p, tomasz.lis,
	Marcin Bernatowicz

Enhance code maintainability, improve error handling, and provide clearer
debugging information.

lib/xe/xe_mmio: Replace open-coded init/cleanup with existing functions

Use intel_register_access_init and intel_register_access_fini to handle
initialization and cleanup, reducing code duplication. This improves
maintainability and ensures consistency, including handling forcewake
for Xe.

lib/xe/xe_sriov_provisioning: Refactor range handling and logging

Introduce an append_range helper to reduce code duplication in handling
provisioned PTE ranges. Limit debug logs to the first 70 entries for
clarity and improved reasoning. Enhance error handling by propagating
realloc failures.

tests/xe/xe_sriov_flr: Use SKIP for unmet subcheck prerequisites

Handle missing prerequisites by marking subchecks as SKIP instead of FAIL.
This avoids misleading results suggesting FLR issues when tests haven't
started or conditions aren't met.

v2: Handle missing prerequisites by consistently marking subchecks as
    SKIP instead of FAIL when conditions aren't met. (Lukasz)
    Update range-checking logic to iterate only within valid PTE offsets
    based on MAX_WOPCM_SIZE and GUC_GGTT_TOP.

Marcin Bernatowicz (3):
  lib/xe/xe_mmio: Replace open-coded init/cleanup with existing
    functions
  lib/xe/xe_sriov_provisioning: Refactor range handling and logging
  tests/xe/xe_sriov_flr: Use SKIP for unmet subcheck prerequisites

 lib/xe/xe_mmio.c               | 10 +----
 lib/xe/xe_sriov_provisioning.c | 78 +++++++++++++++++++++++-----------
 tests/intel/xe_sriov_flr.c     | 21 +++++----
 3 files changed, 68 insertions(+), 41 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-11-23 22:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-20 17:37 [PATCH v2 i-g-t 0/3] Improvements for xe_sriov_flr test and xe_mmio lib Marcin Bernatowicz
2024-11-20 17:37 ` [PATCH v2 i-g-t 1/3] lib/xe/xe_mmio: Replace open-coded init/cleanup with existing functions Marcin Bernatowicz
2024-11-20 17:37 ` [PATCH v2 i-g-t 2/3] lib/xe/xe_sriov_provisioning: Refactor range handling and logging Marcin Bernatowicz
2024-11-20 17:37 ` [PATCH v2 i-g-t 3/3] tests/xe/xe_sriov_flr: Use SKIP for unmet subcheck prerequisites Marcin Bernatowicz
2024-11-20 19:24 ` ✓ Fi.CI.BAT: success for Improvements for xe_sriov_flr test and xe_mmio lib (rev2) Patchwork
2024-11-21  3:36 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-23 22:50 ` ✗ i915.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox