Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, Jeevan B <jeevan.b@intel.com>,
	Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
Subject: [PATCH i-g-t 2/3] tests/kms_async_flips: Skip Async flips on joiner output
Date: Wed, 20 Nov 2024 23:13:44 +0530	[thread overview]
Message-ID: <20241120174345.1970095-3-jeevan.b@intel.com> (raw)
In-Reply-To: <20241120174345.1970095-1-jeevan.b@intel.com>

Async flips are disallowed with joiner, but the test commit still
goes through and causes failures. Update the tests to skip on
joiner outputs.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
---
 tests/kms_async_flips.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 5dec71291..486c03b32 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -653,6 +653,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
 		data->allow_fail = false;
 		data->modifier = default_modifier(data);
 		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
+			/* TODO: Remove this workaround when Async+joiner is supported */
+			igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+				      "Joiner mode found, skipping the test\n");
 			test_init_fbs(data);
 			test(data);
 		}
@@ -674,6 +677,9 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
 			igt_dynamic_f("pipe-%s-%s-%s", kmstest_pipe_name(data->pipe),
 				      data->output->name,
 				      igt_fb_modifier_name(data->modifier)) {
+				/* TODO: Remove workaround when Async+joiner is supported */
+				igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+					      "Joiner mode found, skipping the test\n");
 				test_init_fbs(data);
 				test(data);
 			}
-- 
2.25.1


  parent reply	other threads:[~2024-11-20 17:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20 17:43 [PATCH i-g-t 0/3] Skip test if joiner display is connected Jeevan B
2024-11-20 17:43 ` [PATCH i-g-t 1/3] lib/igt_kms: Add is_joiner_mode function Jeevan B
2024-11-21 18:05   ` Sharma, Swati2
2024-11-20 17:43 ` Jeevan B [this message]
2024-11-21 18:07   ` [PATCH i-g-t 2/3] tests/kms_async_flips: Skip Async flips on joiner output Sharma, Swati2
2024-11-20 17:43 ` [PATCH i-g-t 3/3] tests/kms_display_modes: Skip test if joiner display is connected Jeevan B
2024-11-21 18:49   ` Sharma, Swati2
2024-11-20 18:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-11-21  2:51 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-23 13:39 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241120174345.1970095-3-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox