Re: [PATCH i-g-t 3/3] tests/kms_display_modes: Skip test if joiner display is connected

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jeevan,

On 20-11-2024 11:13 pm, Jeevan B wrote:

> High-resolution displays that support joiner modes can cause extended mode
> tests to fail. This commit introduces a check to skip these tests if a
> joiner mode display is connected, ensuring the test suite runs smoothly
> without unnecessary failures.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_display_modes.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index f1d8ab03d..a2ab8f267 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -318,6 +318,8 @@ igt_main
>   		igt_display_require_output(&data.display);
>   
>   		for_each_connected_output(&data.display, output) {
> +			igt_skip_on_f(is_joiner_mode(data.drm_fd, output),
> +				      "Joiner mode found, skipping the test\n");
Add output name too in skip message.
With this fixed,
Patch LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

>   			data.mst_output[count++] = output;
>   			if (output_is_dp_mst(&data, output, dp_mst_outputs))
>   				dp_mst_outputs++;