From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Subject: [PATCH i-g-t v2 3/4] runner/executor: Fix error handling at terminating test
Date: Wed, 20 Nov 2024 19:32:07 +0100 [thread overview]
Message-ID: <20241120183208.146299-4-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20241120183208.146299-1-kamil.konieczny@linux.intel.com>
Instead of just returning and leaking memory and file descriptors
inform user about an error which occurred and terminate
gracefully.
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
runner/executor.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/runner/executor.c b/runner/executor.c
index a5b5c0eab..5a4c2e1b2 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1533,8 +1533,12 @@ static int monitor_output(pid_t child,
}
killed = next_kill_signal(killed);
- if (!kill_child(killed, child))
- return -1;
+ if (!kill_child(killed, child)) {
+ errf("Error at terminating test with %s, errno=%d\n",
+ killed == SIGQUIT ? "SIGQUIT" : "SIGKILL", errno);
+ killed = -1;
+ break; /* while */
+ }
time_killed = time_now;
}
}
--
2.47.0
next prev parent reply other threads:[~2024-11-20 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 18:32 [PATCH i-g-t v2 0/4] runner: Allow limits at dumping dmesg Kamil Konieczny
2024-11-20 18:32 ` [PATCH i-g-t v2 1/4] runner/executor: Check for error at writing dmesg dump Kamil Konieczny
2024-11-27 6:09 ` Peter Senna Tschudin
2024-11-27 15:05 ` [i-g-t,v2,1/4] " Ryszard Knop
2024-11-29 19:31 ` [i-g-t, v2, 1/4] " Kamil Konieczny
2024-11-20 18:32 ` [PATCH i-g-t v2 2/4] runner/executor: Limit reading dmesg to chunks Kamil Konieczny
2024-11-27 15:12 ` [i-g-t,v2,2/4] " Ryszard Knop
2024-11-29 19:24 ` Kamil Konieczny
2024-11-20 18:32 ` Kamil Konieczny [this message]
2024-11-27 14:32 ` [i-g-t,v2,3/4] runner/executor: Fix error handling at terminating test Ryszard Knop
2024-11-20 18:32 ` [PATCH i-g-t v2 4/4] runner/executor: Inform about terminating Kamil Konieczny
2024-11-27 14:32 ` [i-g-t,v2,4/4] " Ryszard Knop
2024-11-20 19:52 ` ✓ Fi.CI.BAT: success for runner: Allow limits at dumping dmesg (rev2) Patchwork
2024-11-21 4:39 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-23 23:06 ` ✗ i915.CI.Full: " Patchwork
2024-11-26 11:54 ` [PATCH i-g-t v2 0/4] runner: Allow limits at dumping dmesg Sokolowski, Jan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120183208.146299-4-kamil.konieczny@linux.intel.com \
--to=kamil.konieczny@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox