Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ryszard Knop <rk@dragonic.eu>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	 igt-dev@lists.freedesktop.org
Subject: Re: [i-g-t,v2,4/4] runner/executor: Inform about terminating
Date: Wed, 27 Nov 2024 15:32:25 +0100	[thread overview]
Message-ID: <eeaabf2942b2b9aae33f97dfce0cd0423eedd7f8.camel@dragonic.eu> (raw)
In-Reply-To: <20241120183208.146299-5-kamil.konieczny@linux.intel.com>

LGTM

Reviewed-by: Ryszard Knop <rk@dragonic.eu>

On Wed, 2024-11-20 at 19:32 +0100, Kamil Konieczny wrote:
> Create a message before terminating a running test and
> inform user what is a cause.
> 
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  runner/executor.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 5a4c2e1b2..316b81575 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -1359,8 +1359,12 @@ static int monitor_output(pid_t child,
>  
>  				aborting = true;
>  				killed = SIGQUIT;
> -				if (!kill_child(killed, child))
> +				if (!kill_child(killed, child)) {
> +					errf("Error terminating child with %s, errno=%d\n",
> +					     killed == SIGQUIT ? "SIGQUIT" : "SIGKILL", errno);
> +
>  					return -1;
> +				}
>  				time_killed = time_now;
>  
>  				continue;

  reply	other threads:[~2024-11-28  8:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20 18:32 [PATCH i-g-t v2 0/4] runner: Allow limits at dumping dmesg Kamil Konieczny
2024-11-20 18:32 ` [PATCH i-g-t v2 1/4] runner/executor: Check for error at writing dmesg dump Kamil Konieczny
2024-11-27  6:09   ` Peter Senna Tschudin
2024-11-27 15:05   ` [i-g-t,v2,1/4] " Ryszard Knop
2024-11-29 19:31     ` [i-g-t, v2, 1/4] " Kamil Konieczny
2024-11-20 18:32 ` [PATCH i-g-t v2 2/4] runner/executor: Limit reading dmesg to chunks Kamil Konieczny
2024-11-27 15:12   ` [i-g-t,v2,2/4] " Ryszard Knop
2024-11-29 19:24     ` Kamil Konieczny
2024-11-20 18:32 ` [PATCH i-g-t v2 3/4] runner/executor: Fix error handling at terminating test Kamil Konieczny
2024-11-27 14:32   ` [i-g-t,v2,3/4] " Ryszard Knop
2024-11-20 18:32 ` [PATCH i-g-t v2 4/4] runner/executor: Inform about terminating Kamil Konieczny
2024-11-27 14:32   ` Ryszard Knop [this message]
2024-11-20 19:52 ` ✓ Fi.CI.BAT: success for runner: Allow limits at dumping dmesg (rev2) Patchwork
2024-11-21  4:39 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-23 23:06 ` ✗ i915.CI.Full: " Patchwork
2024-11-26 11:54 ` [PATCH i-g-t v2 0/4] runner: Allow limits at dumping dmesg Sokolowski, Jan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeaabf2942b2b9aae33f97dfce0cd0423eedd7f8.camel@dragonic.eu \
    --to=rk@dragonic.eu \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox