Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2] tests/intel/kms_dsc: Add meaningfull skip message
@ 2024-11-26  5:46 Pranay Samala
  2024-11-26  6:32 ` ✓ Xe.CI.BAT: success for tests/intel/kms_dsc: Add meaningfull skip message (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Pranay Samala @ 2024-11-26  5:46 UTC (permalink / raw)
  To: igt-dev
  Cc: karthik.b.s, swati2.sharma, jeevan.b, sameer.lattannavar,
	pranay.samala

This patch adds a proper skip message which will be
easy to debug.

v2: Small clean up in if statement

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel/kms_dsc.c | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
index 9b48caf76..5ebb12e9d 100644
--- a/tests/intel/kms_dsc.c
+++ b/tests/intel/kms_dsc.c
@@ -280,21 +280,6 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
 		data->output = output;
 		data->pipe = pipe;
 
-		if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
-		    !check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||
-		     igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
-			continue;
-
-		if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
-		    (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
-						     data->output, data->output_format)))
-			continue;
-
-		if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
-		    (!is_dsc_fractional_bpp_supported(data->disp_ver,
-						      data->drm_fd, data->output)))
-			continue;
-
 		if (test_type & TEST_DSC_OUTPUT_FORMAT)
 			snprintf(&name[0][0], LEN, "-%s", kmstest_dsc_output_format_str(data->output_format));
 		if (test_type & TEST_DSC_FORMAT)
@@ -303,8 +288,25 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
 			snprintf(&name[2][0], LEN, "-%dbpc", data->input_bpc);
 
 		igt_dynamic_f("pipe-%s-%s%s%s%s",  kmstest_pipe_name(data->pipe), data->output->name,
-			      &name[0][0], &name[1][0], &name[2][0])
+			      &name[0][0], &name[1][0], &name[2][0]) {
+			if (!is_dsc_supported_by_sink(data->drm_fd, data->output) ||
+			    !check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||
+			    igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
+				continue;
+
+			if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
+			    (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
+							     data->output, data->output_format)))
+				igt_skip("DSC %s output format not supported on pipe-%s\n",
+					 kmstest_dsc_output_format_str(data->output_format),
+					 kmstest_pipe_name(data->pipe));
+
+			if ((test_type & TEST_DSC_FRACTIONAL_BPP) &&
+			    (!is_dsc_fractional_bpp_supported(data->disp_ver,
+							      data->drm_fd, data->output)))
+				continue;
 			update_display(data, test_type);
+		}
 
 		if (data->limited)
 			break;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-26 11:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-26  5:46 [PATCH i-g-t v2] tests/intel/kms_dsc: Add meaningfull skip message Pranay Samala
2024-11-26  6:32 ` ✓ Xe.CI.BAT: success for tests/intel/kms_dsc: Add meaningfull skip message (rev2) Patchwork
2024-11-26  7:09 ` ✓ i915.CI.BAT: " Patchwork
2024-11-26  7:24 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-26  8:30 ` ✗ i915.CI.Full: " Patchwork
2024-11-26 11:53 ` [PATCH i-g-t v2] tests/intel/kms_dsc: Add meaningfull skip message Sharma, Swati2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox