Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Subject: [PATCH i-g-t 1/2] tests/kms_scaling_modes: Add informative messages for skipped scaling mode tests
Date: Thu, 28 Nov 2024 00:35:29 +0530	[thread overview]
Message-ID: <20241127190530.3421021-2-ramanaidu.naladala@intel.com> (raw)
In-Reply-To: <20241127190530.3421021-1-ramanaidu.naladala@intel.com>

Add `igt_info` messages to provide more context when skipping outputs
that do not support scaling mode. Include `igt_info` messages to
indicate when invalid pipe/output combinations are skipped.

Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
---
 tests/kms_scaling_modes.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
index 5fd34c4b2..dd2c6426c 100644
--- a/tests/kms_scaling_modes.c
+++ b/tests/kms_scaling_modes.c
@@ -117,12 +117,17 @@ static void test_scaling_mode(data_t *data, uint32_t flags)
 	for_each_pipe_with_valid_output(display, pipe, output) {
 		igt_display_reset(display);
 
-		if (!has_scaling_mode(output))
+		if (!has_scaling_mode(output)) {
+			igt_info("Output %s does not support scaling mode.\n",
+				  igt_output_name(output));
 			continue;
+		}
 
 		igt_output_set_pipe(output, pipe);
-		if (!intel_pipe_output_combo_valid(display))
+		if (!intel_pipe_output_combo_valid(display)) {
+			igt_info("Skipping invalid pipe/output combination.\n");
 			continue;
+		}
 
 		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
 			test_scaling_mode_on_output(display, pipe, output, flags);
-- 
2.43.0


  reply	other threads:[~2024-11-27 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 19:05 [PATCH i-g-t 0/2] Update skip messages in scaling modes Naladala Ramanaidu
2024-11-27 19:05 ` Naladala Ramanaidu [this message]
2024-11-28  4:22   ` [PATCH i-g-t 1/2] tests/kms_scaling_modes: Add informative messages for skipped scaling mode tests Samala, Pranay
2024-12-09  7:03   ` Sharma, Swati2
2024-11-27 19:05 ` [PATCH i-g-t 2/2] HAX patch do not merge Naladala Ramanaidu
2024-11-27 19:36 ` ✓ Xe.CI.BAT: success for Update skip messages in scaling modes Patchwork
2024-11-27 19:53 ` ✓ i915.CI.BAT: " Patchwork
2024-11-27 20:40 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-27 21:25 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241127190530.3421021-2-ramanaidu.naladala@intel.com \
    --to=ramanaidu.naladala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox