Re: [PATCH i-g-t 1/2] tests/kms_scaling_modes: Add informative messages for skipped scaling mode tests

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Ramanaidu,

On 28-11-2024 12:35 am, Naladala Ramanaidu wrote:
> Add `igt_info` messages to provide more context when skipping outputs
> that do not support scaling mode. Include `igt_info` messages to
> indicate when invalid pipe/output combinations are skipped.
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> ---
>   tests/kms_scaling_modes.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
> index 5fd34c4b2..dd2c6426c 100644
> --- a/tests/kms_scaling_modes.c
> +++ b/tests/kms_scaling_modes.c
> @@ -117,12 +117,17 @@ static void test_scaling_mode(data_t *data, uint32_t flags)
>   	for_each_pipe_with_valid_output(display, pipe, output) {
>   		igt_display_reset(display);
>   
> -		if (!has_scaling_mode(output))
> +		if (!has_scaling_mode(output)) {
> +			igt_info("Output %s does not support scaling mode.\n",

Please update the igt_info as igt_info("%s: Doesn't support 
IGT_CONNECTOR_SCALING_MODE\n", igt_output_name(output));


> +				  igt_output_name(output));
>   			continue;
> +		}
>   
>   		igt_output_set_pipe(output, pipe);
> -		if (!intel_pipe_output_combo_valid(display))
> +		if (!intel_pipe_output_combo_valid(display)) {
> +			igt_info("Skipping invalid pipe/output combination.\n");
>   			continue;
> +		}
>   
>   		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
>   			test_scaling_mode_on_output(display, pipe, output, flags);