From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Jan Sokolowski <jan.sokolowski@intel.com>,
Ryszard Knop <rk@dragonic.eu>
Subject: [PATCH i-g-t v3 2/3] runner/executor: Fix error handling at terminating test
Date: Fri, 29 Nov 2024 21:45:49 +0100 [thread overview]
Message-ID: <20241129204550.116355-3-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20241129204550.116355-1-kamil.konieczny@linux.intel.com>
Instead of just returning and leaking memory and file descriptors
inform user about an error which occurred and terminate
gracefully.
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Ryszard Knop <rk@dragonic.eu>
---
runner/executor.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/runner/executor.c b/runner/executor.c
index 16b12ba16..82e5ca5eb 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1510,8 +1510,12 @@ static int monitor_output(pid_t child,
}
killed = next_kill_signal(killed);
- if (!kill_child(killed, child))
- return -1;
+ if (!kill_child(killed, child)) {
+ errf("Error at terminating test with %s, errno=%d\n",
+ killed == SIGQUIT ? "SIGQUIT" : "SIGKILL", errno);
+ killed = -1;
+ break; /* while */
+ }
time_killed = time_now;
}
}
--
2.47.1
next prev parent reply other threads:[~2024-11-29 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 20:45 [PATCH i-g-t v3 0/3] runner: Allow limits at dumping dmesg Kamil Konieczny
2024-11-29 20:45 ` [PATCH i-g-t v3 1/3] runner/executor: Limit reading dmesg to chunks Kamil Konieczny
2024-11-29 20:45 ` Kamil Konieczny [this message]
2024-11-29 20:45 ` [PATCH i-g-t v3 3/3] runner/executor: Inform about terminating Kamil Konieczny
2024-11-29 21:43 ` ✓ Xe.CI.BAT: success for runner: Allow limits at dumping dmesg (rev3) Patchwork
2024-11-29 21:53 ` ✓ i915.CI.BAT: " Patchwork
2024-11-29 23:34 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-02 14:46 ` Kamil Konieczny
2024-11-30 7:10 ` ✗ Xe.CI.Full: " Patchwork
2024-12-02 14:48 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129204550.116355-3-kamil.konieczny@linux.intel.com \
--to=kamil.konieczny@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jan.sokolowski@intel.com \
--cc=rk@dragonic.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox