Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Jan Sokolowski <jan.sokolowski@intel.com>,
	Ryszard Knop <rk@dragonic.eu>
Subject: [PATCH i-g-t v3 3/3] runner/executor: Inform about terminating
Date: Fri, 29 Nov 2024 21:45:50 +0100	[thread overview]
Message-ID: <20241129204550.116355-4-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20241129204550.116355-1-kamil.konieczny@linux.intel.com>

Create a message before terminating a running test and
inform user what is a cause.

Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Ryszard Knop <rk@dragonic.eu>
---
 runner/executor.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/runner/executor.c b/runner/executor.c
index 82e5ca5eb..49ae8c90d 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1336,8 +1336,12 @@ static int monitor_output(pid_t child,
 
 				aborting = true;
 				killed = SIGQUIT;
-				if (!kill_child(killed, child))
+				if (!kill_child(killed, child)) {
+					errf("Error terminating child with %s, errno=%d\n",
+					     killed == SIGQUIT ? "SIGQUIT" : "SIGKILL", errno);
+
 					return -1;
+				}
 				time_killed = time_now;
 
 				continue;
-- 
2.47.1


  parent reply	other threads:[~2024-11-29 20:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 20:45 [PATCH i-g-t v3 0/3] runner: Allow limits at dumping dmesg Kamil Konieczny
2024-11-29 20:45 ` [PATCH i-g-t v3 1/3] runner/executor: Limit reading dmesg to chunks Kamil Konieczny
2024-11-29 20:45 ` [PATCH i-g-t v3 2/3] runner/executor: Fix error handling at terminating test Kamil Konieczny
2024-11-29 20:45 ` Kamil Konieczny [this message]
2024-11-29 21:43 ` ✓ Xe.CI.BAT: success for runner: Allow limits at dumping dmesg (rev3) Patchwork
2024-11-29 21:53 ` ✓ i915.CI.BAT: " Patchwork
2024-11-29 23:34 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-02 14:46   ` Kamil Konieczny
2024-11-30  7:10 ` ✗ Xe.CI.Full: " Patchwork
2024-12-02 14:48   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241129204550.116355-4-kamil.konieczny@linux.intel.com \
    --to=kamil.konieczny@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jan.sokolowski@intel.com \
    --cc=rk@dragonic.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox