From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 4/9] tests/kms_sharpness_filter: Add toggle subtest
Date: Wed, 4 Dec 2024 13:56:22 +0530 [thread overview]
Message-ID: <20241204082627.1800617-5-swati2.sharma@intel.com> (raw)
In-Reply-To: <20241204082627.1800617-1-swati2.sharma@intel.com>
Subtest is added to verify toggling/switching between enabling
and disabling of content adaptive sharpness filter.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_sharpness_filter.c | 40 ++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/tests/kms_sharpness_filter.c b/tests/kms_sharpness_filter.c
index ac12d13bf..8ade3b0bc 100644
--- a/tests/kms_sharpness_filter.c
+++ b/tests/kms_sharpness_filter.c
@@ -34,6 +34,9 @@
* SUBTEST: filter-formats
* Description: Verify content adaptive sharpness filter with varying formats.
* Functionality: casf, pixel-format
+ *
+ * SUBTEST: filter-toggle
+ * Description: Verify toggling between enabling and disabling content adaptive sharpness filter.
*/
IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
@@ -44,9 +47,11 @@ IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
* is seen without corruption for each subtest.
*/
+#define DISABLE_FILTER 0
#define MIN_FILTER_STRENGTH 1
#define MID_FILTER_STRENGTH 128
#define MAX_FILTER_STRENGTH 255
+#define NROUNDS 10
enum test_type {
TEST_FILTER_BASIC,
@@ -54,6 +59,7 @@ enum test_type {
TEST_FILTER_ROTATION,
TEST_FILTER_FORMATS,
TEST_FILTER_STRENGTH,
+ TEST_FILTER_TOGGLE,
};
const int filter_strength_list[] = {
@@ -145,6 +151,23 @@ static void cleanup(data_t *data)
cleanup_fbs(data);
}
+static int test_filter_toggle(data_t *data)
+{
+ int ret = 0;
+
+ for (int k = 0; k < NROUNDS; k++) {
+ if (k % 2 == 0)
+ data->filter_strength = DISABLE_FILTER;
+ else
+ data->filter_strength = MAX_FILTER_STRENGTH;
+
+ set_filter_strength_on_pipe(data);
+ ret |= igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ }
+
+ return ret;
+}
+
static void test_sharpness_filter(data_t *data, enum test_type type)
{
drmModeModeInfo *mode = data->mode;
@@ -171,6 +194,9 @@ static void test_sharpness_filter(data_t *data, enum test_type type)
ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ if (type == TEST_FILTER_TOGGLE)
+ ret |= test_filter_toggle(data);
+
igt_assert_eq(ret, 0);
cleanup(data);
@@ -227,6 +253,9 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
case TEST_FILTER_STRENGTH:
snprintf(name, sizeof(name), "-strength-%d", data->filter_strength);
break;
+ case TEST_FILTER_TOGGLE:
+ snprintf(name, sizeof(name), "-toggle");
+ break;
default:
igt_assert(0);
}
@@ -340,6 +369,17 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
}
}
+ igt_describe("Verify toggling between enabling and disabling "
+ "content adaptive sharpness filter.");
+ igt_subtest_with_dynamic("filter-toggle") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+
+ data.filter_strength = MAX_FILTER_STRENGTH;
+ run_sharpness_filter_test(&data, TEST_FILTER_TOGGLE);
+ }
+
igt_fixture {
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
--
2.25.1
next prev parent reply other threads:[~2024-12-04 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 8:26 [PATCH i-g-t,v9 0/9] Add new test to validate adaptive sharpness Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t, v2 1/9] lib/igt_kms: Add "sharpness strength" as crtc property Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t, v2 2/9] lib/igt_kms: Add func() to return scaling mode name string Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t, v9 3/9] tests/kms_sharpness_filter: Add adaptive sharpness basic filter tests Swati Sharma
2024-12-04 8:26 ` Swati Sharma [this message]
2024-12-04 8:26 ` [PATCH i-g-t 5/9] tests/kms_sharpness_filter: Add filter-tap subtest Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t 6/9] tests/kms_sharpness_filter: Add dpms/suspend subtests Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t 7/9] tests/kms_sharpness_filter: Add scaler subtests Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t 8/9] tests/kms_sharpness_filter: Add invalid subtests Swati Sharma
2024-12-04 8:26 ` [PATCH i-g-t 9/9] tests/chamelium/kms_chamelium_sharpness_filter: Add basic test Swati Sharma
-- strict thread matches above, loose matches on Subject: below --
2024-12-09 11:46 [PATCH i-g-t 0/9] Add new test to validate adaptive sharpness filter Swati Sharma
2024-12-09 11:46 ` [PATCH i-g-t 4/9] tests/kms_sharpness_filter: Add toggle subtest Swati Sharma
2024-12-11 7:57 ` Nautiyal, Ankit K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204082627.1800617-5-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox