Re: [PATCH i-g-t 4/9] tests/kms_sharpness_filter: Add toggle subtest

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/9/2024 5:16 PM, Swati Sharma wrote:
> Subtest is added to verify toggling/switching between enabling
> and disabling of content adaptive sharpness filter.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>

Use imperative mood in commit message.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> ---
>   tests/kms_sharpness_filter.c | 40 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 40 insertions(+)
>
> diff --git a/tests/kms_sharpness_filter.c b/tests/kms_sharpness_filter.c
> index bf660cb02..aa200b16a 100644
> --- a/tests/kms_sharpness_filter.c
> +++ b/tests/kms_sharpness_filter.c
> @@ -34,6 +34,9 @@
>    * SUBTEST: filter-formats
>    * Description: Verify content adaptive sharpness filter with varying formats.
>    * Functionality: casf, pixel-format
> + *
> + * SUBTEST: filter-toggle
> + * Description: Verify toggling between enabling and disabling content adaptive sharpness filter.
>   */
>   
>   IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
> @@ -44,9 +47,11 @@ IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
>    * is seen without corruption for each subtest.
>    */
>   
> +#define DISABLE_FILTER			0
>   #define MIN_FILTER_STRENGTH		1
>   #define MID_FILTER_STRENGTH		128
>   #define MAX_FILTER_STRENGTH		255
> +#define NROUNDS				10
>   
>   enum test_type {
>   	TEST_FILTER_BASIC,
> @@ -54,6 +59,7 @@ enum test_type {
>   	TEST_FILTER_ROTATION,
>   	TEST_FILTER_FORMATS,
>   	TEST_FILTER_STRENGTH,
> +	TEST_FILTER_TOGGLE,
>   };
>   
>   const int filter_strength_list[] = {
> @@ -145,6 +151,23 @@ static void cleanup(data_t *data)
>   	cleanup_fbs(data);
>   }
>   
> +static int test_filter_toggle(data_t *data)
> +{
> +	int ret = 0;
> +
> +	for (int k = 0; k < NROUNDS; k++) {
> +		if (k % 2 == 0)
> +			data->filter_strength = DISABLE_FILTER;
> +		else
> +			data->filter_strength = MAX_FILTER_STRENGTH;
> +
> +		set_filter_strength_on_pipe(data);
> +		ret |= igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> +	}
> +
> +	return ret;
> +}
> +
>   static void test_sharpness_filter(data_t *data,  enum test_type type)
>   {
>   	drmModeModeInfo *mode = data->mode;
> @@ -171,6 +194,9 @@ static void test_sharpness_filter(data_t *data,  enum test_type type)
>   
>   	ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>   
> +	if (type == TEST_FILTER_TOGGLE)
> +		ret |= test_filter_toggle(data);
> +
>   	igt_assert_eq(ret, 0);
>   
>   	cleanup(data);
> @@ -227,6 +253,9 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>   			case TEST_FILTER_STRENGTH:
>   				snprintf(name, sizeof(name), "-strength-%d", data->filter_strength);
>   				break;
> +			case TEST_FILTER_TOGGLE:
> +				snprintf(name, sizeof(name), "-toggle");
> +				break;
>   			default:
>   				igt_assert(0);
>   			}
> @@ -339,6 +368,17 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
>   		}
>   	}
>   
> +	igt_describe("Verify toggling between enabling and disabling "
> +		     "content adaptive sharpness filter.");
> +	igt_subtest_with_dynamic("filter-toggle") {
> +		data.modifier = DRM_FORMAT_MOD_LINEAR;
> +		data.rotation = IGT_ROTATION_0;
> +		data.format = DRM_FORMAT_XRGB8888;
> +
> +		data.filter_strength = MAX_FILTER_STRENGTH;
> +		run_sharpness_filter_test(&data, TEST_FILTER_TOGGLE);
> +	}
> +
>   	igt_fixture {
>   		igt_display_fini(&data.display);
>   		drm_close_driver(data.drm_fd);