From: <george.zhang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <santhosh.reddy.guddati@intel.com>, <sunpeng.li@amd.com>,
<chiahsuan.chung@amd.com>, <alex.hung@amd.com>,
George Zhang <george.zhang@amd.com>
Subject: [PATCH] tests/kms_async_flips: Only check joiner mode on intel device
Date: Tue, 10 Dec 2024 15:12:07 -0500 [thread overview]
Message-ID: <20241210201207.917722-1-george.zhang@amd.com> (raw)
From: George Zhang <george.zhang@amd.com>
The joiner mode check causes the kms_async_flip tests to fail on
non-intel devices. Added a guard to only check the joiner mode if
running on intel device.
Signed-off-by: George Zhang <george.zhang@amd.com>
---
tests/kms_async_flips.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 4a72be7b5..5e7c64d73 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -706,8 +706,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
* FIXME: joiner+async flip is busted currently in KMD.
* Remove this check once the issues are fixed in KMD.
*/
- igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
- "Skipping, async flip not supported on joiner mode\n");
+ if (is_intel_device(data->drm_fd))
+ igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+ "Skipping, async flip not supported on joiner mode\n");
test_init_fbs(data);
test(data);
}
@@ -733,10 +734,11 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
* FIXME: joiner+async flip is busted currently in KMD.
* Remove this check once the issues are fixed in KMD.
*/
- igt_skip_on_f(is_joiner_mode(data->drm_fd,
+ if (is_intel_device(data->drm_fd))
+ igt_skip_on_f(is_joiner_mode(data->drm_fd,
data->output),
- "Skipping, async flip not supported "
- "on joiner mode\n");
+ "Skipping, async flip not supported "
+ "on joiner mode\n");
test_init_fbs(data);
test(data);
}
--
2.34.1
next reply other threads:[~2024-12-10 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 20:12 george.zhang [this message]
2024-12-10 20:59 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Only check joiner mode on intel device Patchwork
2024-12-10 21:20 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-10 21:56 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-10 23:33 ` ✗ Xe.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-12-10 22:39 [PATCH] " george.zhang
2024-12-11 1:56 ` Reddy Guddati, Santhosh
2024-12-11 9:47 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210201207.917722-1-george.zhang@amd.com \
--to=george.zhang@amd.com \
--cc=alex.hung@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=santhosh.reddy.guddati@intel.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox