Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
To: <george.zhang@amd.com>, <igt-dev@lists.freedesktop.org>
Cc: <sunpeng.li@amd.com>, <chiahsuan.chung@amd.com>, <alex.hung@amd.com>
Subject: Re: [PATCH] tests/kms_async_flips: Only check joiner mode on intel device
Date: Wed, 11 Dec 2024 07:26:00 +0530	[thread overview]
Message-ID: <c347987a-6424-410d-ab1b-40eaf5cd1393@intel.com> (raw)
In-Reply-To: <20241210223903.954518-1-george.zhang@amd.com>

Hi George Zhang,

Changes LGTM.

On 11-12-2024 04:09, george.zhang@amd.com wrote:
> From: George Zhang <george.zhang@amd.com>
> 
> The joiner mode check causes the kms_async_flip tests to fail on
> non-intel devices. Added a guard to only check the joiner mode if
> running on intel device.
> 
> v2: Moved guard to within is_joiner_mode function
> 
> Signed-off-by: George Zhang <george.zhang@amd.com>
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
>   lib/igt_kms.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 43ca2d4c2..3d061abc5 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6467,6 +6467,9 @@ bool is_joiner_mode(int drm_fd, igt_output_t *output)
>   	int max_dotclock;
>   	drmModeModeInfo mode;
>   
> +        if (!is_intel_device(drm_fd))
> +                return false;
> +
>   	max_dotclock = igt_get_max_dotclock(drm_fd);
>   	is_joiner = bigjoiner_mode_found(drm_fd,
>   					 output->config.connector,


  parent reply	other threads:[~2024-12-11  1:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 22:39 [PATCH] tests/kms_async_flips: Only check joiner mode on intel device george.zhang
2024-12-10 23:17 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Only check joiner mode on intel device (rev2) Patchwork
2024-12-10 23:50 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-11  0:18 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-11  1:56 ` Reddy Guddati, Santhosh [this message]
2024-12-11  2:55 ` ✗ Xe.CI.Full: " Patchwork
2024-12-11  9:47 ` [PATCH] tests/kms_async_flips: Only check joiner mode on intel device Kamil Konieczny
2024-12-12  6:59 ` ✓ i915.CI.Full: success for tests/kms_async_flips: Only check joiner mode on intel device (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-12-10 20:12 [PATCH] tests/kms_async_flips: Only check joiner mode on intel device george.zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c347987a-6424-410d-ab1b-40eaf5cd1393@intel.com \
    --to=santhosh.reddy.guddati@intel.com \
    --cc=alex.hung@amd.com \
    --cc=chiahsuan.chung@amd.com \
    --cc=george.zhang@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox