From: Christoph Manszewski <christoph.manszewski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>,
"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
"Christoph Manszewski" <christoph.manszewski@intel.com>
Subject: [PATCH i-g-t 1/2] tests/xe_eudebug: Set NEEDS_VISIBLE_VRAM for 'create_bind_list'
Date: Wed, 11 Dec 2024 20:17:40 +0100 [thread overview]
Message-ID: <20241211191741.36973-1-christoph.manszewski@intel.com> (raw)
The 'create_bind_list' function supports custom bo placement. Some subtests
like 'basic-vm-access' can request vram placement and use xe_bo_map
without setting the 'NEEDS_VISIBLE_VRAM' flag, which can result in a
segmentation fault. Enable the 'NEEDS_VISIBLE_VRAM' flag by default, since
the 'xe_bo_map' igt funtion unsets it automatically for non vram backed
bos.
Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
---
tests/intel/xe_eudebug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/intel/xe_eudebug.c b/tests/intel/xe_eudebug.c
index 39db16457..22b0da658 100644
--- a/tests/intel/xe_eudebug.c
+++ b/tests/intel/xe_eudebug.c
@@ -241,7 +241,8 @@ static union buf_id *vm_create_objects(int fd, uint32_t bo_placement, uint32_t v
for (i = 0; i < n; i++) {
if (bo_placement) {
- bo[i].fd = xe_bo_create(fd, vm, size, bo_placement, 0);
+ bo[i].fd = xe_bo_create(fd, vm, size, bo_placement,
+ DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
igt_assert(bo[i].fd);
} else {
bo[i].userptr = aligned_alloc(PAGE_SIZE, size);
--
2.34.1
next reply other threads:[~2024-12-11 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 19:17 Christoph Manszewski [this message]
2024-12-11 19:17 ` [PATCH i-g-t 2/2] lib/xe_eudebug: Fix and update event filters Christoph Manszewski
2024-12-12 8:50 ` Piatkowski, Dominik Karol
2024-12-12 17:07 ` Mika Kuoppala
2024-12-11 20:52 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,1/2] tests/xe_eudebug: Set NEEDS_VISIBLE_VRAM for 'create_bind_list' Patchwork
2024-12-11 21:14 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-12 0:40 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-12 3:06 ` ✗ i915.CI.Full: " Patchwork
2024-12-12 8:46 ` [PATCH i-g-t 1/2] " Piatkowski, Dominik Karol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211191741.36973-1-christoph.manszewski@intel.com \
--to=christoph.manszewski@intel.com \
--cc=dominik.grzegorzek@intel.com \
--cc=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox