Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 1/2] tests/xe_eudebug: Set NEEDS_VISIBLE_VRAM for 'create_bind_list'
@ 2024-12-11 19:17 Christoph Manszewski
  2024-12-11 19:17 ` [PATCH i-g-t 2/2] lib/xe_eudebug: Fix and update event filters Christoph Manszewski
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Christoph Manszewski @ 2024-12-11 19:17 UTC (permalink / raw)
  To: igt-dev
  Cc: Dominik Karol Piątkowski, Dominik Grzegorzek,
	Christoph Manszewski

The 'create_bind_list' function supports custom bo placement. Some subtests
like 'basic-vm-access' can request vram placement and use xe_bo_map
without setting the 'NEEDS_VISIBLE_VRAM' flag, which can result in a
segmentation fault. Enable the 'NEEDS_VISIBLE_VRAM' flag by default, since
the 'xe_bo_map' igt funtion unsets it automatically for non vram backed
bos.

Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
---
 tests/intel/xe_eudebug.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/intel/xe_eudebug.c b/tests/intel/xe_eudebug.c
index 39db16457..22b0da658 100644
--- a/tests/intel/xe_eudebug.c
+++ b/tests/intel/xe_eudebug.c
@@ -241,7 +241,8 @@ static union buf_id *vm_create_objects(int fd, uint32_t bo_placement, uint32_t v
 
 	for (i = 0; i < n; i++) {
 		if (bo_placement) {
-			bo[i].fd = xe_bo_create(fd, vm, size, bo_placement, 0);
+			bo[i].fd = xe_bo_create(fd, vm, size, bo_placement,
+						DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
 			igt_assert(bo[i].fd);
 		} else {
 			bo[i].userptr = aligned_alloc(PAGE_SIZE, size);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-12-12 17:06 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 19:17 [PATCH i-g-t 1/2] tests/xe_eudebug: Set NEEDS_VISIBLE_VRAM for 'create_bind_list' Christoph Manszewski
2024-12-11 19:17 ` [PATCH i-g-t 2/2] lib/xe_eudebug: Fix and update event filters Christoph Manszewski
2024-12-12  8:50   ` Piatkowski, Dominik Karol
2024-12-12 17:07   ` Mika Kuoppala
2024-12-11 20:52 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,1/2] tests/xe_eudebug: Set NEEDS_VISIBLE_VRAM for 'create_bind_list' Patchwork
2024-12-11 21:14 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-12  0:40 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-12  3:06 ` ✗ i915.CI.Full: " Patchwork
2024-12-12  8:46 ` [PATCH i-g-t 1/2] " Piatkowski, Dominik Karol

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox