From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, santhosh.reddy.guddati@intel.com,
Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 5/6] tests/intel/kms_cdclk.c: Modify skip condition
Date: Tue, 31 Dec 2024 00:33:14 +0530 [thread overview]
Message-ID: <20241230190315.48821-6-swati2.sharma@intel.com> (raw)
In-Reply-To: <20241230190315.48821-1-swati2.sharma@intel.com>
Add vrefresh also as a parameter to check if highest and
lowest refresh rates are identical.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/intel/kms_cdclk.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
index 67efdaa3f..fcbfa3f37 100644
--- a/tests/intel/kms_cdclk.c
+++ b/tests/intel/kms_cdclk.c
@@ -223,7 +223,9 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
mode_hi.vrefresh >= VREFRESH, "Mode >= 4K not found on output %s.\n",
igt_output_name(output));
- igt_skip_on_f(mode_hi.hdisplay == mode_lo.hdisplay && mode_hi.vdisplay == mode_lo.vdisplay,
+ igt_skip_on_f(mode_hi.hdisplay == mode_lo.hdisplay &&
+ mode_hi.vdisplay == mode_lo.vdisplay &&
+ mode_hi.vrefresh == mode_lo.vrefresh,
"Highest and lowest mode resolutions are same; no transition\n");
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -302,7 +304,8 @@ static void test_mode_transition_on_all_outputs(data_t *data)
lowres_mode = *get_lowres_mode(output);
if (highres_mode.hdisplay == lowres_mode.hdisplay &&
- highres_mode.vdisplay == lowres_mode.vdisplay) {
+ highres_mode.vdisplay == lowres_mode.vdisplay &&
+ highres_mode.vrefresh == lowres_mode.vrefresh) {
igt_info("Highest and lowest mode resolutions are same on output %s; no transition will occur, skipping\n",
igt_output_name(output));
continue;
--
2.25.1
next prev parent reply other threads:[~2024-12-30 18:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 19:03 [PATCH i-g-t 0/6] tests/intel/kms_cdclk: Refactor mode setting and CD clock verification Swati Sharma
2024-12-30 19:03 ` [PATCH i-g-t 1/6] lib/igt_kms: Add highres() and lowres() func Swati Sharma
2025-01-27 11:32 ` Reddy Guddati, Santhosh
2025-01-28 5:51 ` Reddy Guddati, Santhosh
2025-02-03 13:47 ` Nautiyal, Ankit K
2024-12-30 19:03 ` [PATCH i-g-t 2/6] tests/intel/kms_cdclk: Modify highest resolution restriction Swati Sharma
2024-12-30 19:03 ` [PATCH i-g-t 3/6] tests/intel/kms_cdclk: Add conditions to filter valid outputs Swati Sharma
2025-02-03 14:05 ` Nautiyal, Ankit K
2024-12-30 19:03 ` [PATCH i-g-t 4/6] tests/intel/kms_cdclk: Introduce set_mode() Swati Sharma
2025-02-03 14:11 ` Nautiyal, Ankit K
2024-12-30 19:03 ` Swati Sharma [this message]
2025-02-03 14:12 ` [PATCH i-g-t 5/6] tests/intel/kms_cdclk.c: Modify skip condition Nautiyal, Ankit K
2024-12-30 19:03 ` [PATCH i-g-t 6/6] tests/intel/kms_cdclk: Add get_max_cdclk_freq() Swati Sharma
2024-12-30 19:43 ` ✓ i915.CI.BAT: success for tests/intel/kms_cdclk: Refactor mode setting and CD clock verification (rev2) Patchwork
2024-12-30 19:47 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-30 21:56 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-30 22:20 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241230190315.48821-6-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=santhosh.reddy.guddati@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox