Re: [PATCH i-g-t 5/6] tests/intel/kms_cdclk.c: Modify skip condition

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/31/2024 12:33 AM, Swati Sharma wrote:
> Add vrefresh also as a parameter to check if highest and
> lowest refresh rates are identical.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/intel/kms_cdclk.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
> index 67efdaa3f..fcbfa3f37 100644
> --- a/tests/intel/kms_cdclk.c
> +++ b/tests/intel/kms_cdclk.c
> @@ -223,7 +223,9 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
>   		      mode_hi.vrefresh >= VREFRESH, "Mode >= 4K not found on output %s.\n",
>   		      igt_output_name(output));
>   
> -	igt_skip_on_f(mode_hi.hdisplay == mode_lo.hdisplay && mode_hi.vdisplay == mode_lo.vdisplay,
> +	igt_skip_on_f(mode_hi.hdisplay == mode_lo.hdisplay &&
> +		      mode_hi.vdisplay == mode_lo.vdisplay &&

This can be part of patch were the condition is introduced Patch#3.

Regards,

Ankit

> +		      mode_hi.vrefresh == mode_lo.vrefresh,
>   		      "Highest and lowest mode resolutions are same; no transition\n");
>   
>   	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> @@ -302,7 +304,8 @@ static void test_mode_transition_on_all_outputs(data_t *data)
>   		lowres_mode = *get_lowres_mode(output);
>   
>   		if (highres_mode.hdisplay == lowres_mode.hdisplay &&
> -		    highres_mode.vdisplay == lowres_mode.vdisplay) {
> +		    highres_mode.vdisplay == lowres_mode.vdisplay &&
> +		    highres_mode.vrefresh == lowres_mode.vrefresh) {
>   			igt_info("Highest and lowest mode resolutions are same on output %s; no transition will occur, skipping\n",
>   				  igt_output_name(output));
>   			continue;