From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, jeevan.b@intel.com,
sameer.lattannavar@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t v2] tests/intel/kms_dirtyfb: Add logs to skips
Date: Mon, 6 Jan 2025 09:29:03 +0530 [thread overview]
Message-ID: <20250106035903.22776-1-pranay.samala@intel.com> (raw)
Having some logs for test failures & skips would
make debugging much easier.
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/intel/kms_dirtyfb.c | 37 ++++++++++++++++++++++++++++---------
1 file changed, 28 insertions(+), 9 deletions(-)
diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 35df9be3b..4cbd1a2f9 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -102,21 +102,40 @@ static bool check_support(data_t *data)
case FEATURE_NONE:
return true;
case FEATURE_FBC:
- if (!intel_fbc_supported_on_chipset(data->drm_fd, data->pipe))
+ if (!intel_fbc_supported_on_chipset(data->drm_fd, data->pipe)) {
+ igt_info("FBC is not supported on this chipset\n");
return false;
+ }
+
+ if (!intel_fbc_plane_size_supported(data->drm_fd,
+ data->mode->hdisplay,
+ data->mode->vdisplay)) {
+ igt_info("Plane size not supported as per FBC size restrictions\n");
+ return false;
+ }
+ return true;
- return intel_fbc_plane_size_supported(data->drm_fd,
- data->mode->hdisplay,
- data->mode->vdisplay);
case FEATURE_PSR:
if (data->output->config.connector->connector_type !=
- DRM_MODE_CONNECTOR_eDP)
+ DRM_MODE_CONNECTOR_eDP) {
+ igt_info("Output is not an eDP\n");
+ return false;
+ }
+ if (!psr_sink_support(data->drm_fd, data->debugfs_fd,
+ PSR_MODE_1, NULL)) {
+ igt_info("Output doesn't support PSR\n");
return false;
- return psr_sink_support(data->drm_fd, data->debugfs_fd,
- PSR_MODE_1, NULL);
+ }
+ return true;
+
case FEATURE_DRRS:
- return intel_is_drrs_supported(data->drm_fd, data->pipe) &&
- intel_output_has_drrs(data->drm_fd, data->output);
+ if (!(intel_is_drrs_supported(data->drm_fd, data->pipe) &&
+ intel_output_has_drrs(data->drm_fd, data->output))) {
+ igt_info("Output doesn't support DRRS\n");
+ return false;
+ }
+ return true;
+
case FEATURE_DEFAULT:
return true;
default:
--
2.34.1
next reply other threads:[~2025-01-06 3:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 3:59 Pranay Samala [this message]
2025-01-06 4:16 ` [PATCH i-g-t v2] tests/intel/kms_dirtyfb: Add logs to skips B, Jeevan
2025-01-06 4:17 ` B, Jeevan
2025-01-06 4:49 ` ✗ GitLab.Pipeline: warning for tests/intel/kms_dirtyfb: Add logs to skips (rev2) Patchwork
2025-01-06 4:55 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-06 5:02 ` ✗ i915.CI.BAT: failure " Patchwork
2025-01-06 6:32 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106035903.22776-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox