Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2] tests/intel/kms_dirtyfb: Add logs to skips
@ 2025-01-06  3:59 Pranay Samala
  2025-01-06  4:16 ` B, Jeevan
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Pranay Samala @ 2025-01-06  3:59 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, jeevan.b, sameer.lattannavar, pranay.samala

Having some logs for test failures & skips would
make debugging much easier.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_dirtyfb.c | 37 ++++++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 9 deletions(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 35df9be3b..4cbd1a2f9 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -102,21 +102,40 @@ static bool check_support(data_t *data)
 	case FEATURE_NONE:
 		return true;
 	case FEATURE_FBC:
-		if (!intel_fbc_supported_on_chipset(data->drm_fd, data->pipe))
+		if (!intel_fbc_supported_on_chipset(data->drm_fd, data->pipe)) {
+			igt_info("FBC is not supported on this chipset\n");
 			return false;
+		}
+
+		if (!intel_fbc_plane_size_supported(data->drm_fd,
+						    data->mode->hdisplay,
+						    data->mode->vdisplay)) {
+			igt_info("Plane size not supported as per FBC size restrictions\n");
+			return false;
+		}
+		return true;
 
-		return intel_fbc_plane_size_supported(data->drm_fd,
-						      data->mode->hdisplay,
-						      data->mode->vdisplay);
 	case FEATURE_PSR:
 		if (data->output->config.connector->connector_type !=
-		    DRM_MODE_CONNECTOR_eDP)
+		    DRM_MODE_CONNECTOR_eDP) {
+			igt_info("Output is not an eDP\n");
+			return false;
+		}
+		if (!psr_sink_support(data->drm_fd, data->debugfs_fd,
+				      PSR_MODE_1, NULL)) {
+			igt_info("Output doesn't support PSR\n");
 			return false;
-		return psr_sink_support(data->drm_fd, data->debugfs_fd,
-					PSR_MODE_1, NULL);
+		}
+		return true;
+
 	case FEATURE_DRRS:
-		return intel_is_drrs_supported(data->drm_fd, data->pipe) &&
-			intel_output_has_drrs(data->drm_fd, data->output);
+		if (!(intel_is_drrs_supported(data->drm_fd, data->pipe) &&
+		      intel_output_has_drrs(data->drm_fd, data->output))) {
+			igt_info("Output doesn't support DRRS\n");
+			return false;
+		}
+		return true;
+
 	case FEATURE_DEFAULT:
 		return true;
 	default:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-01-06  6:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06  3:59 [PATCH i-g-t v2] tests/intel/kms_dirtyfb: Add logs to skips Pranay Samala
2025-01-06  4:16 ` B, Jeevan
2025-01-06  4:17   ` B, Jeevan
2025-01-06  4:49 ` ✗ GitLab.Pipeline: warning for tests/intel/kms_dirtyfb: Add logs to skips (rev2) Patchwork
2025-01-06  4:55 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-06  5:02 ` ✗ i915.CI.BAT: failure " Patchwork
2025-01-06  6:32 ` ✗ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox