Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ashutosh.dixit@intel.com, sai.teja.pottumuttu@intel.com,
	Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: [PATCH i-g-t v3 1/3] tests/intel/xe_oa: Remove unused function arguments
Date: Mon, 13 Jan 2025 11:49:47 +0530	[thread overview]
Message-ID: <20250113061949.753864-2-sai.teja.pottumuttu@intel.com> (raw)
In-Reply-To: <20250113061949.753864-1-sai.teja.pottumuttu@intel.com>

The oa_exponent argument is unused in oa_report_is_periodic
function. Thus remove it.

Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 tests/intel/xe_oa.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 492a6b5d6..ad3526406 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -791,7 +791,7 @@ emit_report_perf_count(struct intel_bb *ibb,
 }
 
 static bool
-oa_report_is_periodic(uint32_t oa_exponent, const uint32_t *report)
+oa_report_is_periodic(const uint32_t *report)
 {
 	if (report_reason(report) & OAREPORT_REASON_TIMER)
 		return true;
@@ -1342,7 +1342,7 @@ read_2_oa_reports(int format_id,
 			igt_assert_neq_u64(oa_timestamp(report, format_id), 0);
 
 			if (timer_only) {
-				if (!oa_report_is_periodic(exponent, report)) {
+				if (!oa_report_is_periodic(report)) {
 					igt_debug("skipping non timer report\n");
 					continue;
 				}
@@ -1752,7 +1752,7 @@ static void test_oa_exponents(const struct drm_xe_engine_class_instance *hwe)
 				if (oa_status & DRM_XE_OASTATUS_REPORT_LOST)
 					igt_debug("report loss\n");
 
-				if (!oa_report_is_periodic(exponent, report))
+				if (!oa_report_is_periodic(report))
 					continue;
 
 				memcpy(timer_reports, report, format_size);
@@ -1969,7 +1969,7 @@ static void test_blocking(uint64_t requested_oa_period,
 		for (int offset = 0; offset < ret; offset += format_size) {
 			uint32_t *report = (void *)(buf + offset);
 
-			if (oa_report_is_periodic(oa_exponent, report))
+			if (oa_report_is_periodic(report))
 				timer_report_read = true;
 			else
 				non_timer_report_read = true;
@@ -2142,7 +2142,7 @@ static void test_polling(uint64_t requested_oa_period,
 		for (int offset = 0; offset < ret; offset += format_size) {
 			uint32_t *report = (void *)(buf + offset);
 
-			if (oa_report_is_periodic(oa_exponent, report))
+			if (oa_report_is_periodic(report))
 				timer_report_read = true;
 			else
 				non_timer_report_read = true;
@@ -2463,7 +2463,7 @@ again_1:
 					  " ts_delta_last_periodic=%"PRIu64" is_timer=%i ctx_id=%8x nb_periodic=%u\n",
 					  oa_timestamp(report, fmt),
 					  n_periodic_reports > 0 ?  oa_timestamp_delta(report, last_periodic_report, fmt) : 0,
-					  oa_report_is_periodic(oa_exponent, report),
+					  oa_report_is_periodic(report),
 					  oa_report_get_ctx_id(report),
 					  n_periodic_reports);
 
@@ -2471,7 +2471,7 @@ again_1:
 					first_timestamp = oa_timestamp(report, fmt);
 				last_timestamp = oa_timestamp(report, fmt);
 
-				if (oa_report_is_periodic(oa_exponent, report)) {
+				if (oa_report_is_periodic(report)) {
 					memcpy(last_periodic_report, report, report_size);
 					n_periodic_reports++;
 				}
@@ -2677,12 +2677,12 @@ test_enable_disable(const struct drm_xe_engine_class_instance *hwe)
 					  " ts_delta_last_periodic=%s%"PRIu64""
 					  " is_timer=%i ctx_id=0x%8x\n",
 					  oa_timestamp(report, fmt),
-					  oa_report_is_periodic(oa_exponent, report) ? " " : "*",
+					  oa_report_is_periodic(report) ? " " : "*",
 					  n_periodic_reports > 0 ?  oa_timestamp_delta(report, last_periodic_report, fmt) : 0,
-					  oa_report_is_periodic(oa_exponent, report),
+					  oa_report_is_periodic(report),
 					  oa_report_get_ctx_id(report));
 
-				if (oa_report_is_periodic(oa_exponent, report)) {
+				if (oa_report_is_periodic(report)) {
 					memcpy(last_periodic_report, report, report_size);
 
 					/* We want to measure only the periodic reports,
@@ -4380,7 +4380,7 @@ static void check_reports(void *oa_vaddr, uint32_t oa_size,
 	for (reports = (uint32_t *)oa_vaddr;
 	     timer_reports < 20 && reports[0] && oa_timestamp(reports, fmt);
 	     reports += report_words) {
-		if (!oa_report_is_periodic(oa_exp_1_millisec, reports))
+		if (!oa_report_is_periodic(reports))
 			continue;
 
 		timer_reports++;
-- 
2.34.1


  reply	other threads:[~2025-01-13  6:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13  6:19 [PATCH i-g-t v3 0/3] Miscellaneous OA Refactors Sai Teja Pottumuttu
2025-01-13  6:19 ` Sai Teja Pottumuttu [this message]
2025-01-13  6:19 ` [PATCH i-g-t v3 2/3] tests/intel/xe_oa: Reduce the number of mmap reports checked Sai Teja Pottumuttu
2025-01-13 19:22   ` Dixit, Ashutosh
2025-01-13  6:19 ` [PATCH i-g-t v3 3/3] tests/intel/xe_oa: Remove hardcoded time heuristics Sai Teja Pottumuttu
2025-01-13 19:37   ` Dixit, Ashutosh
2025-01-13 21:17 ` ✓ i915.CI.BAT: success for Miscellaneous OA Refactors (rev3) Patchwork
2025-01-13 21:18 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-15  7:13 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-17  8:00 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113061949.753864-2-sai.teja.pottumuttu@intel.com \
    --to=sai.teja.pottumuttu@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox