From: Pravalika Gurram <pravalika.gurram@intel.com>
To: igt-dev@lists.freedesktop.org, kamil.konieczny@linux.intel.com,
peter.senna@linux.intel.com
Cc: Pravalika Gurram <pravalika.gurram@intel.com>
Subject: [PATCH 1/2] lib/igt_facts: Make igt_facts_test noreturn
Date: Tue, 21 Jan 2025 12:02:06 +0530 [thread overview]
Message-ID: <20250121063207.71737-2-pravalika.gurram@intel.com> (raw)
In-Reply-To: <20250121063207.71737-1-pravalika.gurram@intel.com>
noreturn attribute is used to improve the optimization by informing to
the compiler that function does not return .
Signed-off-by: Pravalika Gurram <pravalika.gurram@intel.com>
---
lib/igt_facts.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/igt_facts.c b/lib/igt_facts.c
index 2e04a7c86..bd6742065 100644
--- a/lib/igt_facts.c
+++ b/lib/igt_facts.c
@@ -748,7 +748,7 @@ static void igt_facts_test_mark_and_sweep(struct igt_list_head *head)
*
* Returns: bool indicating if the tests passed
*/
-void igt_facts_test(void)
+__noreturn void igt_facts_test(void)
{
const char *last_test = "Unit Testing";
@@ -776,4 +776,6 @@ void igt_facts_test(void)
/* Clean up the list and call igt_facts(). This should not crash */
igt_facts_list_mark_and_sweep(&igt_facts_list_pci_gpu_head);
igt_facts(last_test);
+
+ igt_exit();
}
--
2.34.1
next prev parent reply other threads:[~2025-01-21 6:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 6:32 [PATCH 0/2] Make igt_facts_test noreturn and cleanup Pravalika Gurram
2025-01-21 6:32 ` Pravalika Gurram [this message]
2025-01-21 8:21 ` [PATCH 1/2] lib/igt_facts: Make igt_facts_test noreturn Peter Senna Tschudin
2025-01-21 9:14 ` Gurram, Pravalika
2025-01-21 9:30 ` Peter Senna Tschudin
2025-01-21 14:02 ` Kamil Konieczny
2025-01-21 6:32 ` [PATCH 2/2] lib/igt_facts : Cleanup Pravalika Gurram
2025-01-21 8:32 ` Peter Senna Tschudin
2025-01-21 13:58 ` Kamil Konieczny
2025-01-21 13:52 ` Kamil Konieczny
2025-01-21 13:55 ` Kamil Konieczny
2025-01-21 9:18 ` ✗ GitLab.Pipeline: warning for Make igt_facts_test noreturn and cleanup Patchwork
2025-01-21 9:23 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-21 10:48 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-21 14:26 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-21 17:26 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121063207.71737-2-pravalika.gurram@intel.com \
--to=pravalika.gurram@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=peter.senna@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox