Re: [PATCH 1/2] lib/igt_facts: Make igt_facts_test noreturn

[Peter Senna Tschudin <peter.senna@linux.intel.com>]

Hi Pravalika,

On 21.01.2025 07:32, Pravalika Gurram wrote:
> noreturn attribute is used to improve the optimization by informing to
> the compiler that function does not return .
> 
> Signed-off-by: Pravalika Gurram <pravalika.gurram@intel.com>
> ---
>  lib/igt_facts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_facts.c b/lib/igt_facts.c
> index 2e04a7c86..bd6742065 100644
> --- a/lib/igt_facts.c
> +++ b/lib/igt_facts.c
> @@ -748,7 +748,7 @@ static void igt_facts_test_mark_and_sweep(struct igt_list_head *head)
>   *
>   * Returns: bool indicating if the tests passed
>   */
> -void igt_facts_test(void)
> +__noreturn void igt_facts_test(void)

How did you find this? Is the compiler complaining?

>  {
>  	const char *last_test = "Unit Testing";
>  
> @@ -776,4 +776,6 @@ void igt_facts_test(void)
>  	/* Clean up the list and call igt_facts(). This should not crash */
>  	igt_facts_list_mark_and_sweep(&igt_facts_list_pci_gpu_head);
>  	igt_facts(last_test);
> +
> +	igt_exit();
>  }
Why adding igt_exit() here?

How did you test this patch?

Thanks,

Peter