Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Gustavo Sousa <gustavo.sousa@intel.com>,
	Peter Senna Tschudin <peter.senna@linux.intel.com>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Ryszard Knop <ryszard.knop@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t v2 1/7] runner/settings: Deduplicate cleanup
Date: Tue, 21 Jan 2025 14:57:27 -0800	[thread overview]
Message-ID: <20250121225733.808978-2-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20250121225733.808978-1-lucas.demarchi@intel.com>

Deduplicate cleanup so it's also easy to parse the line in a different
way.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 runner/settings.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/runner/settings.c b/runner/settings.c
index 92fd42ea6..80d95be5b 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -1154,13 +1154,10 @@ bool serialize_settings(struct settings *settings)
 
 bool read_settings_from_file(struct settings *settings, FILE *f)
 {
-#define PARSE_LINE(s, name, val, field, write) \
-	if (!strcmp(name, #field)) {	       \
-		s->field = write;	       \
-		free(name);		       \
-		free(val);		       \
-		name = val = NULL;	       \
-		continue;		       \
+#define PARSE_LINE(s, name, val, field, write)	\
+	if (!strcmp(name, #field)) {		\
+		s->field = write;		\
+		goto cleanup;			\
 	}
 
 	char *name = NULL, *val = NULL;
@@ -1195,6 +1192,8 @@ bool read_settings_from_file(struct settings *settings, FILE *f)
 
 		printf("Warning: Unknown field in settings file: %s = %s\n",
 		       name, val);
+
+cleanup:
 		free(name);
 		free(val);
 		name = val = NULL;
-- 
2.48.0


  reply	other threads:[~2025-01-21 22:57 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 22:57 [PATCH i-g-t v2 0/7] Add igt_runner's cmdline to results Lucas De Marchi
2025-01-21 22:57 ` Lucas De Marchi [this message]
2025-01-22 10:50   ` [PATCH i-g-t v2 1/7] runner/settings: Deduplicate cleanup Gustavo Sousa
2025-01-22 12:22     ` Peter Senna Tschudin
2025-01-21 22:57 ` [PATCH i-g-t v2 2/7] runner/settings: Use wrapper functions for each type Lucas De Marchi
2025-01-22 11:20   ` Gustavo Sousa
2025-01-23  6:07     ` Lucas De Marchi
2025-01-23 11:20       ` Gustavo Sousa
2025-01-22 12:21   ` Peter Senna Tschudin
2025-01-23  6:22     ` Lucas De Marchi
2025-01-21 22:57 ` [PATCH i-g-t v2 3/7] runner/settings: Drop extra strdup Lucas De Marchi
2025-01-22 11:34   ` Gustavo Sousa
2025-01-22 12:22     ` Peter Senna Tschudin
2025-01-23  6:23     ` Lucas De Marchi
2025-01-23 11:15       ` Gustavo Sousa
2025-01-21 22:57 ` [PATCH i-g-t v2 4/7] runner/settings: Fix code_coverage_script leak Lucas De Marchi
2025-01-22 11:37   ` Gustavo Sousa
2025-01-22 12:23     ` Peter Senna Tschudin
2025-01-21 22:57 ` [PATCH i-g-t v2 5/7] runner: Free settings at the end Lucas De Marchi
2025-01-22 11:46   ` Gustavo Sousa
2025-01-22 12:23     ` Peter Senna Tschudin
2025-01-23  6:28     ` Lucas De Marchi
2025-01-24 17:25       ` Lucas De Marchi
2025-01-21 22:57 ` [PATCH i-g-t v2 6/7] runner/settings: Serialize command line Lucas De Marchi
2025-01-22 12:25   ` Peter Senna Tschudin
2025-01-22 12:40   ` Gustavo Sousa
2025-01-22 18:16     ` Peter Senna Tschudin
2025-01-22 18:26       ` Gustavo Sousa
2025-01-22 18:35         ` Peter Senna Tschudin
2025-01-22 18:55           ` Gustavo Sousa
2025-01-23  6:43             ` Lucas De Marchi
2025-01-22 18:53         ` Peter Senna Tschudin
2025-01-28 18:37   ` Kamil Konieczny
2025-01-28 19:34     ` Lucas De Marchi
2025-01-29 17:23       ` Kamil Konieczny
2025-01-29 18:09         ` Petri Latvala
2025-01-29 20:29           ` Lucas De Marchi
2025-01-29 20:15         ` Lucas De Marchi
2025-01-21 22:57 ` [PATCH i-g-t v2 7/7] runner/resultgen: Add cmdline to results.json Lucas De Marchi
2025-01-22 12:25   ` Peter Senna Tschudin
2025-01-22 12:51   ` Gustavo Sousa
2025-01-23  6:50     ` Lucas De Marchi
2025-01-24 14:20       ` Knop, Ryszard
2025-01-29 18:14         ` Petri Latvala
2025-01-22  1:45 ` ✓ Xe.CI.BAT: success for Add igt_runner's cmdline to results (rev2) Patchwork
2025-01-22  1:49 ` ✓ i915.CI.BAT: " Patchwork
2025-01-22 10:11 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-23 10:42 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121225733.808978-2-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=peter.senna@linux.intel.com \
    --cc=ryszard.knop@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox