From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Gustavo Sousa <gustavo.sousa@intel.com>,
Peter Senna Tschudin <peter.senna@linux.intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Ryszard Knop <ryszard.knop@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t v2 6/7] runner/settings: Serialize command line
Date: Tue, 21 Jan 2025 14:57:32 -0800 [thread overview]
Message-ID: <20250121225733.808978-7-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20250121225733.808978-1-lucas.demarchi@intel.com>
Serialize the command line to metadata.txt. The expected format in the
metadata.txt is like below:
cmdline.argc : 6
cmdline.argv[0] : ./build/runner/igt_runner
cmdline.argv[1] : -o
cmdline.argv[2] : --test-list
cmdline.argv[3] : /tmp/testlist.txt
cmdline.argv[4] : build/tests/
cmdline.argv[5] : /tmp/results
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
runner/settings.c | 42 ++++++++++++++++++++++++++++++++++++++++++
runner/settings.h | 5 +++++
2 files changed, 47 insertions(+)
diff --git a/runner/settings.c b/runner/settings.c
index 2787869ee..ed1afc205 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -529,6 +529,18 @@ static void free_hook_strs(struct igt_vec *hook_strs)
igt_vec_fini(hook_strs);
}
+static void free_cmdline(struct settings *settings)
+{
+ if (!settings->cmdline.allocated)
+ return;
+
+ for (size_t i = 0; i < settings->cmdline.argc; i++)
+ free(settings->cmdline.argv[i]);
+
+ free(settings->cmdline.argv);
+}
+
+
static bool file_exists_at(int dirfd, const char *filename)
{
return faccessat(dirfd, filename, F_OK, 0) == 0;
@@ -646,6 +658,7 @@ void clear_settings(struct settings *settings)
free_regexes(&settings->exclude_regexes);
free_env_vars(&settings->env_vars);
free_hook_strs(&settings->hook_strs);
+ free_cmdline(settings);
init_settings(settings);
}
@@ -875,6 +888,8 @@ bool parse_options(int argc, char **argv,
goto error;
}
+ settings->cmdline.argc = argc;
+ settings->cmdline.argv = argv;
return true;
@@ -1055,6 +1070,7 @@ static bool serialize_hook_strs(struct settings *settings, int dirfd)
bool serialize_settings(struct settings *settings)
{
#define SERIALIZE_LINE(f, s, name, format) fprintf(f, "%s : " format "\n", #name, s->name)
+#define SERIALIZE_ARRAY_ITEM(f, s, name, _i, format) fprintf(f, "%s[%d] : " format "\n", #name, _i, s->name[_i])
FILE *f;
int dirfd, covfd;
@@ -1123,6 +1139,10 @@ bool serialize_settings(struct settings *settings)
SERIALIZE_LINE(f, settings, cov_results_per_test, "%d");
SERIALIZE_LINE(f, settings, code_coverage_script, "%s");
+ SERIALIZE_LINE(f, settings, cmdline.argc, "%d");
+ for (int i = 0; i < settings->cmdline.argc; i++)
+ SERIALIZE_ARRAY_ITEM(f, settings, cmdline.argv, i, "%s");
+
if (settings->sync) {
fflush(f);
fsync(fileno(f));
@@ -1177,9 +1197,21 @@ static char *parse_str(char **pval)
s->field = _f(&val); \
goto cleanup; \
}
+#define PARSE_LINE_ARRAY(s, name, val, field, _f, _max) \
+ do { \
+ int idx; \
+ if (sscanf(name, #field "[%u]", &idx) == 1 && \
+ idx < s->_max) { \
+ s->field[idx] = _f(&val); \
+ goto cleanup; \
+ } \
+ } while (0)
+
#define PARSE_INT(s, name, val, field) PARSE_LINE(s, name, val, field, parse_int)
#define PARSE_UL(s, name, val, field) PARSE_LINE(s, name, val, field, parse_ul)
#define PARSE_STR(s, name, val, field) PARSE_LINE(s, name, val, field, parse_str)
+#define PARSE_ARRAY_STR(s, name, val, field, _max) \
+ PARSE_LINE_ARRAY(s, name, val, field, parse_str, _max)
bool read_settings_from_file(struct settings *settings, FILE *f)
{
@@ -1211,6 +1243,15 @@ bool read_settings_from_file(struct settings *settings, FILE *f)
PARSE_INT(settings, name, val, enable_code_coverage);
PARSE_INT(settings, name, val, cov_results_per_test);
PARSE_STR(settings, name, val, code_coverage_script);
+ PARSE_INT(settings, name, val, cmdline.argc);
+
+ if (settings->cmdline.argc && !settings->cmdline.argv) {
+ settings->cmdline.allocated = true;
+ settings->cmdline.argv = calloc(settings->cmdline.argc,
+ sizeof(*settings->cmdline.argv));
+ }
+
+ PARSE_ARRAY_STR(settings, name, val, cmdline.argv, cmdline.argc);
printf("Warning: Unknown field in settings file: %s = %s\n",
name, val);
@@ -1234,6 +1275,7 @@ cleanup:
return true;
}
#undef PARSE_LINE
+#undef PARSE_LINE_ARRAY
/**
* read_env_vars_from_file() - load env vars from a file
diff --git a/runner/settings.h b/runner/settings.h
index f69f09778..d563a0d16 100644
--- a/runner/settings.h
+++ b/runner/settings.h
@@ -75,6 +75,11 @@ struct settings {
char *code_coverage_script;
bool enable_code_coverage;
bool cov_results_per_test;
+ struct {
+ bool allocated;
+ int argc;
+ char **argv;
+ } cmdline;
};
/**
--
2.48.0
next prev parent reply other threads:[~2025-01-21 22:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 22:57 [PATCH i-g-t v2 0/7] Add igt_runner's cmdline to results Lucas De Marchi
2025-01-21 22:57 ` [PATCH i-g-t v2 1/7] runner/settings: Deduplicate cleanup Lucas De Marchi
2025-01-22 10:50 ` Gustavo Sousa
2025-01-22 12:22 ` Peter Senna Tschudin
2025-01-21 22:57 ` [PATCH i-g-t v2 2/7] runner/settings: Use wrapper functions for each type Lucas De Marchi
2025-01-22 11:20 ` Gustavo Sousa
2025-01-23 6:07 ` Lucas De Marchi
2025-01-23 11:20 ` Gustavo Sousa
2025-01-22 12:21 ` Peter Senna Tschudin
2025-01-23 6:22 ` Lucas De Marchi
2025-01-21 22:57 ` [PATCH i-g-t v2 3/7] runner/settings: Drop extra strdup Lucas De Marchi
2025-01-22 11:34 ` Gustavo Sousa
2025-01-22 12:22 ` Peter Senna Tschudin
2025-01-23 6:23 ` Lucas De Marchi
2025-01-23 11:15 ` Gustavo Sousa
2025-01-21 22:57 ` [PATCH i-g-t v2 4/7] runner/settings: Fix code_coverage_script leak Lucas De Marchi
2025-01-22 11:37 ` Gustavo Sousa
2025-01-22 12:23 ` Peter Senna Tschudin
2025-01-21 22:57 ` [PATCH i-g-t v2 5/7] runner: Free settings at the end Lucas De Marchi
2025-01-22 11:46 ` Gustavo Sousa
2025-01-22 12:23 ` Peter Senna Tschudin
2025-01-23 6:28 ` Lucas De Marchi
2025-01-24 17:25 ` Lucas De Marchi
2025-01-21 22:57 ` Lucas De Marchi [this message]
2025-01-22 12:25 ` [PATCH i-g-t v2 6/7] runner/settings: Serialize command line Peter Senna Tschudin
2025-01-22 12:40 ` Gustavo Sousa
2025-01-22 18:16 ` Peter Senna Tschudin
2025-01-22 18:26 ` Gustavo Sousa
2025-01-22 18:35 ` Peter Senna Tschudin
2025-01-22 18:55 ` Gustavo Sousa
2025-01-23 6:43 ` Lucas De Marchi
2025-01-22 18:53 ` Peter Senna Tschudin
2025-01-28 18:37 ` Kamil Konieczny
2025-01-28 19:34 ` Lucas De Marchi
2025-01-29 17:23 ` Kamil Konieczny
2025-01-29 18:09 ` Petri Latvala
2025-01-29 20:29 ` Lucas De Marchi
2025-01-29 20:15 ` Lucas De Marchi
2025-01-21 22:57 ` [PATCH i-g-t v2 7/7] runner/resultgen: Add cmdline to results.json Lucas De Marchi
2025-01-22 12:25 ` Peter Senna Tschudin
2025-01-22 12:51 ` Gustavo Sousa
2025-01-23 6:50 ` Lucas De Marchi
2025-01-24 14:20 ` Knop, Ryszard
2025-01-29 18:14 ` Petri Latvala
2025-01-22 1:45 ` ✓ Xe.CI.BAT: success for Add igt_runner's cmdline to results (rev2) Patchwork
2025-01-22 1:49 ` ✓ i915.CI.BAT: " Patchwork
2025-01-22 10:11 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-23 10:42 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121225733.808978-7-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=peter.senna@linux.intel.com \
--cc=ryszard.knop@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox