Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/xe_eudebug_online: breakpoint-many-sessions-* add delay before resume
@ 2025-01-27 12:10 Maciej Patelczyk
  2025-01-27 14:57 ` ✓ i915.CI.BAT: success for tests/xe_eudebug_online: breakpoint-many-sessions-* add delay before resume (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Maciej Patelczyk @ 2025-01-27 12:10 UTC (permalink / raw)
  To: igt-dev; +Cc: dominik.grzegorzek, Maciej Patelczyk

For single tile workloads under debug are executed sequentially.
The test quickly resumes workload that hit the breakpoint without any
delay. That is then catched by the expectation that there shall be a
break between workloads.

Add sleep before resuming workload so that there is a forced gap
between workloads. If they were properly executed sequentially
then the diff between workloads shall be longer than sleep.

Additionally fix the 'ms' to 'us' typo report in case of assert.

Reviewed-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
 tests/intel/xe_eudebug_online.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index 726fc55b1..d3504b79f 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -2305,6 +2305,7 @@ static void test_many_sessions_on_tiles(int fd, bool multi_tile)
 				attempt_mask |= BIT(i);
 				should_break = 1;
 
+				usleep(WORKLOAD_DELAY_US);
 				eus = (struct drm_xe_eudebug_event_eu_attention *)data[i]->exception_event;
 				eu_ctl_resume(s[i]->debugger->master_fd, s[i]->debugger->fd,
 					      eus->client_handle, eus->exec_queue_handle,
@@ -2328,11 +2329,11 @@ static void test_many_sessions_on_tiles(int fd, bool multi_tile)
 
 		if (multi_tile)
 			igt_assert_f(diff < WORKLOAD_DELAY_US,
-				     "Expected to execute workloads concurrently. Actual delay: %" PRIu64 " ms\n",
+				     "Expected to execute workloads concurrently. Actual delay: %" PRIu64 " us\n",
 				     diff);
 		else
 			igt_assert_f(diff >= WORKLOAD_DELAY_US,
-				     "Expected a serialization of workloads. Actual delay: %" PRIu64 " ms\n",
+				     "Expected a serialization of workloads. Actual delay: %" PRIu64 " us\n",
 				     diff);
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH i-g-t] tests/xe_eudebug_online: breakpoint-many-sessions-* add delay before resume
@ 2025-01-24 10:41 Maciej Patelczyk
  2025-01-24 10:47 ` Grzegorzek, Dominik
  0 siblings, 1 reply; 9+ messages in thread
From: Maciej Patelczyk @ 2025-01-24 10:41 UTC (permalink / raw)
  To: igt-dev; +Cc: Maciej Patelczyk

For single tile workloads under debug are executed sequentially.
The test quickly resumes workload that hit the breakpoint without any
delay. That is then catched by the expectation that there shall be a
break between workloads.

Add sleep before resuming workload so that there is a forced gap
between workloads. If they were properly executed sequentially
then the diff between workloads shall be longer than sleep.

Additionally fix the 'ms' to 'us' typo report in case of assert.

Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
 tests/intel/xe_eudebug_online.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index f532387af..d58f7d65f 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -2305,6 +2305,7 @@ static void test_many_sessions_on_tiles(int fd, bool multi_tile)
 				attempt_mask |= BIT(i);
 				should_break = 1;
 
+				usleep(WORKLOAD_DELAY_US);
 				eus = (struct drm_xe_eudebug_event_eu_attention *)data[i]->exception_event;
 				eu_ctl_resume(s[i]->debugger->master_fd, s[i]->debugger->fd,
 					      eus->client_handle, eus->exec_queue_handle,
@@ -2328,11 +2329,11 @@ static void test_many_sessions_on_tiles(int fd, bool multi_tile)
 
 		if (multi_tile)
 			igt_assert_f(diff < WORKLOAD_DELAY_US,
-				     "Expected to execute workloads concurrently. Actual delay: %lu ms\n",
+				     "Expected to execute workloads concurrently. Actual delay: %lu us\n",
 				     diff);
 		else
 			igt_assert_f(diff >= WORKLOAD_DELAY_US,
-				     "Expected a serialization of workloads. Actual delay: %lu ms\n",
+				     "Expected a serialization of workloads. Actual delay: %lu us\n",
 				     diff);
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-01-30  9:28 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-27 12:10 [PATCH i-g-t] tests/xe_eudebug_online: breakpoint-many-sessions-* add delay before resume Maciej Patelczyk
2025-01-27 14:57 ` ✓ i915.CI.BAT: success for tests/xe_eudebug_online: breakpoint-many-sessions-* add delay before resume (rev2) Patchwork
2025-01-27 15:01 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-27 17:47 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-30  9:27   ` Maciej Patelczyk
2025-01-27 22:13 ` ✗ Xe.CI.Full: " Patchwork
2025-01-30  9:27   ` Maciej Patelczyk
  -- strict thread matches above, loose matches on Subject: below --
2025-01-24 10:41 [PATCH i-g-t] tests/xe_eudebug_online: breakpoint-many-sessions-* add delay before resume Maciej Patelczyk
2025-01-24 10:47 ` Grzegorzek, Dominik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox