Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Gustavo Sousa <gustavo.sousa@intel.com>,
	Peter Senna Tschudin <peter.senna@linux.intel.com>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Petri Latvala <adrinael@adrinael.net>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t v3 00/10] Add igt_runner's cmdline to results
Date: Thu, 30 Jan 2025 09:21:39 -0800	[thread overview]
Message-ID: <20250130172149.3657144-1-lucas.demarchi@intel.com> (raw)

Help devs to reproduce what CI is running by dumping what is the command
line being used. While it's true that in the shard case we don't have
the testlist, just seeing the right incantation of command line is a
great improvement.

I plan to follow this with the env vars, but first want to get this
in. It seems we already have an environment.txt saved, however that
doesn't contain the igt_runner's env, only options passed via -e to
igt_runner which is then forwarded to each test. I'm wondering if this
is a source of bugs when using igt_resume:  if the environment doesn't
match, it will run with different options on each execution. (answer:
yes, it is a source of bugs if the exact environment is not re-created
for running igt_resume)

v2:
  - Fix more leaks as prep commits
  - Fix leaking argv that got lost in all other pre-existent leaks
  - Add dummy array to the reference.json files so it passes runner's
    own tests.

v3:
  - Better split patches and reword commit messages according to reviews
    by Gustavo and Peter
  - Add generic escape/unescape functions to be used for metadata.txt.
    Besides preparing for cmdline, it fixes other uses of \n.
  - Provide a single macro to parse array, which adds the proper code
    to parse both the array items and the length

Lucas De Marchi (10):
  runner/settings: Fix code_coverage_script leak
  runner: Free settings at the end
  runner/settings: Deduplicate cleanup
  runner/settings: Use wrapper macros for each type
  runner/settings: Match serialization to parse
  runner/settings: Drop extra strdup
  runner: Fix use of newline on arguments
  runner/settings: Add helpers to serialize/parse array
  runner/settings: Serialize command line
  runner/resultgen: Add cmdline to results.json

 .../aborted-after-a-test/reference.json       |   1 +
 .../aborted-on-boot/reference.json            |   1 +
 .../dmesg-escapes/reference.json              |   1 +
 .../dmesg-results/reference.json              |   1 +
 .../reference.json                            |   1 +
 .../reference.json                            |   1 +
 .../dmesg-warn-level/reference.json           |   1 +
 .../reference.json                            |   1 +
 .../dynamic-subtests-keep-all/reference.json  |   3 +-
 .../reference.json                            |   1 +
 .../reference.json                            |   3 +-
 .../reference.json                            |   3 +-
 .../empty-result-files/reference.json         |   1 +
 .../graceful-notrun/reference.json            |   1 +
 .../reference.json                            |   1 +
 .../json_tests_data/normal-run/reference.json |   1 +
 .../reference.json                            |   1 +
 .../notrun-results/reference.json             |   1 +
 .../piglit-style-dmesg/reference.json         |   1 +
 .../unprintable-characters/reference.json     |   1 +
 .../warnings-with-dmesg-warns/reference.json  |   1 +
 .../json_tests_data/warnings/reference.json   |   1 +
 runner/resultgen.c                            |   7 +-
 runner/resume.c                               |   2 +
 runner/runner.c                               |   2 +
 runner/settings.c                             | 272 ++++++++++++++----
 runner/settings.h                             |   4 +
 27 files changed, 250 insertions(+), 65 deletions(-)

-- 
2.48.0


             reply	other threads:[~2025-01-30 17:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30 17:21 Lucas De Marchi [this message]
2025-01-30 17:21 ` [PATCH i-g-t v3 01/10] runner/settings: Fix code_coverage_script leak Lucas De Marchi
2025-01-30 17:21 ` [PATCH i-g-t v3 02/10] runner: Free settings at the end Lucas De Marchi
2025-01-30 17:21 ` [PATCH i-g-t v3 03/10] runner/settings: Deduplicate cleanup Lucas De Marchi
2025-01-30 17:21 ` [PATCH i-g-t v3 04/10] runner/settings: Use wrapper macros for each type Lucas De Marchi
2025-02-07 18:34   ` Gustavo Sousa
2025-01-30 17:21 ` [PATCH i-g-t v3 05/10] runner/settings: Match serialization to parse Lucas De Marchi
2025-02-07 19:13   ` Gustavo Sousa
2025-01-30 17:21 ` [PATCH i-g-t v3 06/10] runner/settings: Drop extra strdup Lucas De Marchi
2025-01-30 17:21 ` [PATCH i-g-t v3 07/10] runner: Fix use of newline on arguments Lucas De Marchi
2025-01-31  9:21   ` Peter Senna Tschudin
2025-01-31 15:58     ` Lucas De Marchi
2025-02-03 18:09       ` Lucas De Marchi
2025-02-07 20:15         ` Gustavo Sousa
2025-01-30 17:21 ` [PATCH i-g-t v3 08/10] runner/settings: Add helpers to serialize/parse array Lucas De Marchi
2025-02-07 20:26   ` Gustavo Sousa
2025-01-30 17:21 ` [PATCH i-g-t v3 09/10] runner/settings: Serialize command line Lucas De Marchi
2025-02-07 20:36   ` Gustavo Sousa
2025-02-07 20:41     ` Gustavo Sousa
2025-01-30 17:21 ` [PATCH i-g-t v3 10/10] runner/resultgen: Add cmdline to results.json Lucas De Marchi
2025-01-30 19:00   ` Kamil Konieczny
2025-01-30 19:17     ` Lucas De Marchi
2025-01-31  9:31       ` Peter Senna Tschudin
2025-01-31 12:16       ` Kamil Konieczny
2025-01-31 15:39         ` Lucas De Marchi
2025-01-30 19:12 ` ✓ Xe.CI.BAT: success for Add igt_runner's cmdline to results (rev3) Patchwork
2025-01-30 19:12 ` ✓ i915.CI.BAT: " Patchwork
2025-01-30 21:21 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-30 22:06 ` ✓ Xe.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250130172149.3657144-1-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=adrinael@adrinael.net \
    --cc=gustavo.sousa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=peter.senna@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox