Re: [PATCH i-g-t v3 10/10] runner/resultgen: Add cmdline to results.json

[Peter Senna Tschudin <peter.senna@linux.intel.com>]

On 30.01.2025 20:17, Lucas De Marchi wrote:
> On Thu, Jan 30, 2025 at 08:00:55PM +0100, Kamil Konieczny wrote:
>> Hi Lucas,
>> On 2025-01-30 at 09:21:49 -0800, Lucas De Marchi wrote:
>>> For easier repro scenarios, add the cmdline to the json: one can see the
>>> exact command executed to try to reproduce a CI failure without needing
>>> extra files.
>>>
>>> Adding cmdline to the results.json doesn't need a version upgrade:
>>> piglit can still parse the file.
>>
>> Why not just printing this into stdout before executing test loop?
>> The same way which is already used by igt_facts, so it will go
>> into runnerNN.txt log and will not be duplicated in each and every
>> results.json
> 
> igt_facts print things that is happening between the tests. It's
> monitoring the execution.
> 
> I don't understand the push back here when we already add things
> like version, uname, execution time, etc. You could use the same argument and say "look at the runner.log"
> to see the execution time.

I buy the value of having it at the json because:
 - The json and its derivatives seems to be the longest living artifacts.
   Having runtime setup in the json may indeed help us reproduce issues
   even weeks down the line.
 - For those who have tools consuming the json, the new field makes it
   convenient to extract information. The extra fields makes little
   difference for those who don't.
 - The size overhead for the json is insignificant

Peter

[...]