Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Chung <chiahsuan.chung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <alex.hung@amd.com>, <sunpeng.li@amd.com>, <chiahsuan.chung@amd.com>
Subject: [PATCH i-g-t,v3] tests/amdgpu/amd_abm: Disable the ABM after test
Date: Tue, 18 Feb 2025 19:04:32 +0800	[thread overview]
Message-ID: <20250218110514.8856-1-chiahsuan.chung@amd.com> (raw)

[Why]
After running the ABM IGT test, It may cause some other IGT test
failed because of the ABM is still enabled.

[How]
Disable the ABM after running the test.

Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
---
v3: Fix the conflict

 tests/amdgpu/amd_abm.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index e196b6ebc..8f7f489ad 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -49,6 +49,8 @@ typedef struct data {
 	igt_fb_t ref_fb;
 } data_t;
 
+static void set_abm_level(data_t *data, igt_output_t *output, int level);
+
 /* Common test setup. */
 static void test_init(data_t *data)
 {
@@ -101,6 +103,15 @@ static void test_init(data_t *data)
 static void test_fini(data_t *data)
 {
 	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+
+	/* Disable ABM before exit test */
+	for_each_valid_output_on_pipe(&data->display, pipe, output) {
+		if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
+			continue;
+		set_abm_level(data, output, 0);
+	}
 
 	igt_display_reset(display);
 	igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);
-- 
2.43.0


             reply	other threads:[~2025-02-18 11:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 11:04 Tom Chung [this message]
2025-02-18 12:50 ` ✓ i915.CI.BAT: success for tests/amdgpu/amd_abm: Disable the ABM after test (rev3) Patchwork
2025-02-18 13:58 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-18 16:13 ` [PATCH i-g-t, v3] tests/amdgpu/amd_abm: Disable the ABM after test Zhang, George
2025-02-18 17:30 ` ✗ i915.CI.Full: failure for tests/amdgpu/amd_abm: Disable the ABM after test (rev3) Patchwork
2025-02-19  3:56 ` ✗ Xe.CI.Full: " Patchwork
2025-02-19 22:53 ` [PATCH i-g-t, v3] tests/amdgpu/amd_abm: Disable the ABM after test Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250218110514.8856-1-chiahsuan.chung@amd.com \
    --to=chiahsuan.chung@amd.com \
    --cc=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox