Re: [PATCH i-g-t, v3] tests/amdgpu/amd_abm: Disable the ABM after test

[Alex Hung <alex.hung@amd.com>]

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 2/18/25 04:04, Tom Chung wrote:
> [Why]
> After running the ABM IGT test, It may cause some other IGT test
> failed because of the ABM is still enabled.
> 
> [How]
> Disable the ABM after running the test.
> 
> Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
> ---
> v3: Fix the conflict
> 
>   tests/amdgpu/amd_abm.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index e196b6ebc..8f7f489ad 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -49,6 +49,8 @@ typedef struct data {
>   	igt_fb_t ref_fb;
>   } data_t;
>   
> +static void set_abm_level(data_t *data, igt_output_t *output, int level);
> +
>   /* Common test setup. */
>   static void test_init(data_t *data)
>   {
> @@ -101,6 +103,15 @@ static void test_init(data_t *data)
>   static void test_fini(data_t *data)
>   {
>   	igt_display_t *display = &data->display;
> +	igt_output_t *output;
> +	enum pipe pipe;
> +
> +	/* Disable ABM before exit test */
> +	for_each_valid_output_on_pipe(&data->display, pipe, output) {
> +		if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
> +			continue;
> +		set_abm_level(data, output, 0);
> +	}
>   
>   	igt_display_reset(display);
>   	igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);