Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 11/11] lib/igt_frame: Use igt_dynamic_subtest_name()
Date: Fri, 21 Feb 2025 22:27:49 +0530	[thread overview]
Message-ID: <20250221165749.460347-12-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250221165749.460347-1-swati2.sharma@intel.com>

For dumped images, print dynamic subtest name too.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt_frame.c | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/lib/igt_frame.c b/lib/igt_frame.c
index 45523a79f..ff3597718 100644
--- a/lib/igt_frame.c
+++ b/lib/igt_frame.c
@@ -63,19 +63,22 @@ static void igt_write_frame_to_png(cairo_surface_t *surface, int fd,
 	char path[PATH_MAX];
 	const char *test_name;
 	const char *subtest_name;
+	const char *dynamic_subtest_name;
 	cairo_status_t status;
 	int index;
 
 	test_name = igt_test_name();
 	subtest_name = igt_subtest_name();
+	dynamic_subtest_name = igt_dynamic_subtest_name();
 
 	if (suffix)
-		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s-%s.png",
-			 igt_frame_dump_path, test_name, subtest_name, qualifier,
-			 suffix);
+		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s-%s-%s.png",
+			 igt_frame_dump_path, test_name, subtest_name,
+			 dynamic_subtest_name,  qualifier, suffix);
 	else
-		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s.png",
-			 igt_frame_dump_path, test_name, subtest_name, qualifier);
+		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s-%s.png",
+			 igt_frame_dump_path, test_name, subtest_name,
+			 dynamic_subtest_name, qualifier);
 
 	igt_debug("Dumping %s frame to %s...\n", qualifier, path);
 
@@ -110,6 +113,7 @@ void igt_write_compared_frames_to_png(cairo_surface_t *reference,
 	char *id;
 	const char *test_name;
 	const char *subtest_name;
+	const char *dynamic_subtest_name;
 	char path[PATH_MAX];
 	int fd = -1;
 
@@ -120,13 +124,16 @@ void igt_write_compared_frames_to_png(cairo_surface_t *reference,
 
 	test_name = igt_test_name();
 	subtest_name = igt_subtest_name();
+	dynamic_subtest_name = igt_dynamic_subtest_name();
 
 	if (id)
-		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s.txt",
-			 igt_frame_dump_path, test_name, subtest_name, id);
+		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s-%s.txt",
+			 igt_frame_dump_path, test_name, subtest_name,
+			 dynamic_subtest_name, id);
 	else
-		snprintf(path, PATH_MAX, "%s/frame-%s-%s.txt",
-			 igt_frame_dump_path, test_name, subtest_name);
+		snprintf(path, PATH_MAX, "%s/frame-%s-%s-%s.txt",
+			 igt_frame_dump_path, test_name, subtest_name,
+			 dynamic_subtest_name);
 
 	fd = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0644);
 	igt_assert(fd >= 0);
-- 
2.25.1


  parent reply	other threads:[~2025-02-21 16:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 16:57 [PATCH i-g-t 00/11] Add new test to validate adaptive sharpness filter Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v5 01/11] lib/igt_kms: Add "sharpness strength" as crtc property Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 02/11] lib/igt_kms: Add func() to return scaling mode name string Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v10 03/11] tests/kms_sharpness_filter: Add adaptive sharpness basic filter tests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 04/11] tests/kms_sharpness_filter: Add toggle subtest Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 05/11] tests/kms_sharpness_filter: Add filter-tap subtest Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 06/11] tests/kms_sharpness_filter: Add dpms/suspend subtests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 07/11] tests/kms_sharpness_filter: Add scaler subtests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t 08/11] tests/kms_sharpness_filter: Add invalid subtests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v3 09/11] tests/chamelium/kms_chamelium_sharpness_filter: Add basic test Swati Sharma
2025-03-19  5:26   ` [PATCH i-g-t,v3 " Nautiyal, Ankit K
2025-03-19  5:31     ` Nautiyal, Ankit K
2025-02-21 16:57 ` [PATCH i-g-t 10/11] lib/igt_core: Add igt_dynamic_subtest_name() Swati Sharma
2025-03-26  6:00   ` [i-g-t,10/11] " Joshi, Kunal1
2025-02-21 16:57 ` Swati Sharma [this message]
2025-03-26  6:02   ` [i-g-t,11/11] lib/igt_frame: Use igt_dynamic_subtest_name() Joshi, Kunal1
2025-02-21 17:40 ` ✓ Xe.CI.BAT: success for Add new test to validate adaptive sharpness filter (rev12) Patchwork
2025-02-21 17:42 ` ✓ i915.CI.BAT: " Patchwork
2025-02-21 19:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-22  7:35 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250221165749.460347-12-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox