From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t, v2 06/11] tests/kms_sharpness_filter: Add dpms/suspend subtests
Date: Fri, 21 Feb 2025 22:27:44 +0530 [thread overview]
Message-ID: <20250221165749.460347-7-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250221165749.460347-1-swati2.sharma@intel.com>
Add subtests to verify CASF with DPMS and suspend.
v2: -Added CRC based verification (Ankit)
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
tests/kms_sharpness_filter.c | 67 ++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/tests/kms_sharpness_filter.c b/tests/kms_sharpness_filter.c
index d1d6558c5..32ad7a752 100644
--- a/tests/kms_sharpness_filter.c
+++ b/tests/kms_sharpness_filter.c
@@ -41,6 +41,14 @@
* SUBTEST: filter-tap
* Description: Verify content adaptive sharpness filter with resolution change, resolution change
* will lead to selection of distinct taps.
+ *
+ * SUBTEST: filter-dpms
+ * Description: Verify content adaptive sharpness filter with DPMS.
+ * Functionality: casf, dpms
+ *
+ * SUBTEST: filter-suspend
+ * Description: Verify content adaptive sharpness filter with suspend.
+ * Functionality: casf, suspend
*/
IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
@@ -70,6 +78,8 @@ enum test_type {
TEST_FILTER_STRENGTH,
TEST_FILTER_TOGGLE,
TEST_FILTER_TAP,
+ TEST_FILTER_DPMS,
+ TEST_FILTER_SUSPEND,
};
const int filter_strength_list[] = {
@@ -212,9 +222,12 @@ static int test_filter_toggle(data_t *data)
static void test_sharpness_filter(data_t *data, enum test_type type)
{
+ igt_output_t *output = data->output;
drmModeModeInfo *mode = data->mode;
int height = mode->hdisplay;
int width = mode->vdisplay;
+ igt_crc_t ref_crc, crc;
+ igt_pipe_crc_t *pipe_crc = NULL;
int ret;
data->plane[0] = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
@@ -238,11 +251,37 @@ static void test_sharpness_filter(data_t *data, enum test_type type)
ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ if (type == TEST_FILTER_DPMS || type == TEST_FILTER_SUSPEND) {
+ pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe_id,
+ IGT_PIPE_CRC_SOURCE_AUTO);
+ igt_pipe_crc_collect_crc(pipe_crc, &ref_crc);
+ }
+
+ if (type == TEST_FILTER_DPMS) {
+ kmstest_set_connector_dpms(data->drm_fd,
+ output->config.connector,
+ DRM_MODE_DPMS_OFF);
+ kmstest_set_connector_dpms(data->drm_fd,
+ output->config.connector,
+ DRM_MODE_DPMS_ON);
+ }
+
+ if (type == TEST_FILTER_SUSPEND)
+ igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
+ SUSPEND_TEST_NONE);
+
+ if (type == TEST_FILTER_DPMS || type == TEST_FILTER_SUSPEND) {
+ igt_pipe_crc_collect_crc(pipe_crc, &crc);
+ igt_assert_crc_equal(&crc, &ref_crc);
+ }
+
if (type == TEST_FILTER_TOGGLE)
ret |= test_filter_toggle(data);
igt_assert_eq(ret, 0);
+ /* clean-up */
+ igt_pipe_crc_free(pipe_crc);
cleanup(data);
}
@@ -328,6 +367,12 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
case TEST_FILTER_TOGGLE:
snprintf(name, sizeof(name), "-toggle");
break;
+ case TEST_FILTER_DPMS:
+ snprintf(name, sizeof(name), "-dpms");
+ break;
+ case TEST_FILTER_SUSPEND:
+ snprintf(name, sizeof(name), "-suspend");
+ break;
default:
igt_assert(0);
}
@@ -462,6 +507,28 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
run_sharpness_filter_test(&data, TEST_FILTER_TAP);
}
+ igt_describe("Verify content adaptive sharpness filter "
+ "with DPMS.");
+ igt_subtest_with_dynamic("filter-dpms") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_DPMS);
+ }
+
+ igt_describe("Verify content adaptive sharpness filter "
+ "with suspend.");
+ igt_subtest_with_dynamic("filter-suspend") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_SUSPEND);
+ }
+
igt_fixture {
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
--
2.25.1
next prev parent reply other threads:[~2025-02-21 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 16:57 [PATCH i-g-t 00/11] Add new test to validate adaptive sharpness filter Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v5 01/11] lib/igt_kms: Add "sharpness strength" as crtc property Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 02/11] lib/igt_kms: Add func() to return scaling mode name string Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v10 03/11] tests/kms_sharpness_filter: Add adaptive sharpness basic filter tests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 04/11] tests/kms_sharpness_filter: Add toggle subtest Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v2 05/11] tests/kms_sharpness_filter: Add filter-tap subtest Swati Sharma
2025-02-21 16:57 ` Swati Sharma [this message]
2025-02-21 16:57 ` [PATCH i-g-t, v2 07/11] tests/kms_sharpness_filter: Add scaler subtests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t 08/11] tests/kms_sharpness_filter: Add invalid subtests Swati Sharma
2025-02-21 16:57 ` [PATCH i-g-t, v3 09/11] tests/chamelium/kms_chamelium_sharpness_filter: Add basic test Swati Sharma
2025-03-19 5:26 ` [PATCH i-g-t,v3 " Nautiyal, Ankit K
2025-03-19 5:31 ` Nautiyal, Ankit K
2025-02-21 16:57 ` [PATCH i-g-t 10/11] lib/igt_core: Add igt_dynamic_subtest_name() Swati Sharma
2025-03-26 6:00 ` [i-g-t,10/11] " Joshi, Kunal1
2025-02-21 16:57 ` [PATCH i-g-t 11/11] lib/igt_frame: Use igt_dynamic_subtest_name() Swati Sharma
2025-03-26 6:02 ` [i-g-t,11/11] " Joshi, Kunal1
2025-02-21 17:40 ` ✓ Xe.CI.BAT: success for Add new test to validate adaptive sharpness filter (rev12) Patchwork
2025-02-21 17:42 ` ✓ i915.CI.BAT: " Patchwork
2025-02-21 19:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-22 7:35 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221165749.460347-7-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox