From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset before retraining
Date: Mon, 3 Mar 2025 13:38:41 +0530 [thread overview]
Message-ID: <20250303080842.3194642-2-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20250303080842.3194642-1-kunal1.joshi@intel.com>
Retraining can be done on enabled output.
Fix test to do modeset before retraining.
v2: remove redundant modeset (Jeevan)
Fixes: 983ffca5ff96fd67c937691337f4488e28948aa7
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/intel/kms_dp_link_training.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/intel/kms_dp_link_training.c b/tests/intel/kms_dp_link_training.c
index f00376614..e218c9839 100644
--- a/tests/intel/kms_dp_link_training.c
+++ b/tests/intel/kms_dp_link_training.c
@@ -233,6 +233,7 @@ static bool run_link_rate_test(data_t *data, bool mst, bool uhbr)
igt_display_reset(&data->display);
igt_reset_link_params(data->drm_fd, data->output);
+ do_modeset(data, mst);
/* Retrain at default/driver parameters */
igt_force_link_retrain(data->drm_fd, data->output, RETRAIN_COUNT);
@@ -240,7 +241,6 @@ static bool run_link_rate_test(data_t *data, bool mst, bool uhbr)
igt_get_dp_pending_retrain,
1.0, 20.0), 0);
assert_link_status_good(data, mst);
- do_modeset(data, mst);
/* FIXME : Driver may lie max link rate or max lane count */
/* Read max_link_rate and max_lane_count */
--
2.43.0
next prev parent reply other threads:[~2025-03-03 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 8:08 [PATCH i-g-t 0/2] fixes for test kms_dp_link_training Kunal Joshi
2025-03-03 8:08 ` Kunal Joshi [this message]
2025-03-06 5:46 ` [PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset before retraining B, Jeevan
2025-03-03 8:08 ` [PATCH i-g-t 2/2] tests/intel/kms_dp_link_training: fix assert for igt_find_all_mst_output_in_topology Kunal Joshi
2025-03-03 9:25 ` ✓ Xe.CI.BAT: success for fixes for test kms_dp_link_training (rev2) Patchwork
2025-03-03 9:44 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-03 10:31 ` ✗ Xe.CI.Full: " Patchwork
2025-03-06 11:13 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-06 14:20 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303080842.3194642-2-kunal1.joshi@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox