Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t 2/2] tests/intel/kms_dp_link_training: fix assert for igt_find_all_mst_output_in_topology
Date: Mon,  3 Mar 2025 13:38:42 +0530	[thread overview]
Message-ID: <20250303080842.3194642-3-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20250303080842.3194642-1-kunal1.joshi@intel.com>

fix assert for igt_find_all_mst_output_in_topology
as it changed to int from bool

Fixes: 983ffca5ff96fd67c937691337f4488e28948aa7
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel/kms_dp_link_training.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_dp_link_training.c b/tests/intel/kms_dp_link_training.c
index e218c9839..7ee2d17f5 100644
--- a/tests/intel/kms_dp_link_training.c
+++ b/tests/intel/kms_dp_link_training.c
@@ -95,7 +95,7 @@ static void assert_link_status_good(data_t *data, bool mst)
 	if (mst) {
 		igt_assert_f(igt_find_all_mst_output_in_topology(data->drm_fd,
 								 &data->display, data->output,
-								 outputs, &count),
+								 outputs, &count) == 0,
 								 "Unable to find MST outputs\n");
 
 		for (i = 0; i < count; i++) {
@@ -194,7 +194,7 @@ static void do_modeset(data_t *data, bool mst)
 		igt_assert_f(igt_find_all_mst_output_in_topology(data->drm_fd,
 								 &data->display,
 								 data->output, outs,
-								 &out_count),
+								 &out_count) == 0,
 								 "Unable to find MST outputs\n");
 	} else {
 		outs[0] = data->output;
-- 
2.43.0


  parent reply	other threads:[~2025-03-03  7:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03  8:08 [PATCH i-g-t 0/2] fixes for test kms_dp_link_training Kunal Joshi
2025-03-03  8:08 ` [PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset before retraining Kunal Joshi
2025-03-06  5:46   ` B, Jeevan
2025-03-03  8:08 ` Kunal Joshi [this message]
2025-03-03  9:25 ` ✓ Xe.CI.BAT: success for fixes for test kms_dp_link_training (rev2) Patchwork
2025-03-03  9:44 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-03 10:31 ` ✗ Xe.CI.Full: " Patchwork
2025-03-06 11:13 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-06 14:20 ` ✗ i915.CI.Full: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-02-27 12:30 [PATCH i-g-t 0/2] fixes for test kms_dp_link_training Kunal Joshi
2025-02-27 12:30 ` [PATCH i-g-t 2/2] tests/intel/kms_dp_link_training: fix assert for igt_find_all_mst_output_in_topology Kunal Joshi
2025-02-28  5:17   ` B, Jeevan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250303080842.3194642-3-kunal1.joshi@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox