Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/kms_draw_crc: Skip formats not supported by the plane
@ 2025-03-03 11:02 Ville Syrjala
  2025-03-04  0:02 ` ✓ Xe.CI.BAT: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 12+ messages in thread
From: Ville Syrjala @ 2025-03-03 11:02 UTC (permalink / raw)
  To: igt-dev

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The test only checks igt_display_has_format_mod() before
deciding to test a specific format. But that doesn't
mean the actual plane supports that format. Also check
for that once we know which plane to use.

Should turn the fp16 failures into skips on IVB because it
doesn't have fp16 support on the primary plane.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/intel/kms_draw_crc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/intel/kms_draw_crc.c b/tests/intel/kms_draw_crc.c
index 9c350853cfd9..62c6c64be710 100644
--- a/tests/intel/kms_draw_crc.c
+++ b/tests/intel/kms_draw_crc.c
@@ -158,6 +158,8 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format,
 
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 
+	igt_require(igt_plane_has_format_mod(primary, drm_format, modifier));
+
 	igt_create_fb(drm_fd, mode->hdisplay, mode->vdisplay,
 		      drm_format, modifier, &fb);
 	igt_plane_set_fb(primary, &fb);
-- 
2.45.3


^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-03-06 13:01 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-03 11:02 [PATCH i-g-t] tests/intel/kms_draw_crc: Skip formats not supported by the plane Ville Syrjala
2025-03-04  0:02 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-03-04  0:09 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-04  3:47 ` ✗ Xe.CI.Full: " Patchwork
2025-03-05 14:40 ` [PATCH i-g-t] " Juha-Pekka Heikkilä
2025-03-06 13:01   ` Kamil Konieczny
2025-03-06  2:33 ` ✓ Xe.CI.BAT: success for tests/intel/kms_draw_crc: Skip formats not supported by the plane (rev2) Patchwork
2025-03-06  2:51 ` ✓ i915.CI.BAT: " Patchwork
2025-03-06  5:29 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-06 12:47   ` Kamil Konieczny
2025-03-06  7:33 ` ✗ Xe.CI.Full: " Patchwork
2025-03-06 12:46   ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox