Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE
@ 2025-03-06 15:25 Marcin Bernatowicz
  2025-03-06 17:18 ` Kamil Konieczny
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Marcin Bernatowicz @ 2025-03-06 15:25 UTC (permalink / raw)
  To: igt-dev; +Cc: Marcin Bernatowicz, Kamil Konieczny, Kunal Joshi, Arun R Murthy

Commit d7bccece44dd ("tests/intel/kms_dp_link_training: Restrict to Intel
GPUs") missed adding DRIVER_XE. Ensure both DRIVER_INTEL and DRIVER_XE
are set to properly restrict the test to Intel GPUs.

Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Cc: Arun R Murthy <arun.r.murthy@intel.com>
---
 tests/intel/kms_dp_link_training.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/kms_dp_link_training.c b/tests/intel/kms_dp_link_training.c
index 7d3848b94..3df7b6562 100644
--- a/tests/intel/kms_dp_link_training.c
+++ b/tests/intel/kms_dp_link_training.c
@@ -335,7 +335,7 @@ igt_main
 	data_t data = {};
 
 	igt_fixture {
-		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 		data.devid = intel_get_drm_devid(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
 		igt_display_require(&data.display, data.drm_fd);
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE
  2025-03-06 15:25 [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE Marcin Bernatowicz
@ 2025-03-06 17:18 ` Kamil Konieczny
  2025-03-06 19:01 ` Kamil Konieczny
  2025-03-07  2:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Kamil Konieczny @ 2025-03-06 17:18 UTC (permalink / raw)
  To: Marcin Bernatowicz; +Cc: igt-dev, Kunal Joshi, Arun R Murthy

Hi Marcin,
On 2025-03-06 at 16:25:52 +0100, Marcin Bernatowicz wrote:
> Commit d7bccece44dd ("tests/intel/kms_dp_link_training: Restrict to Intel
> GPUs") missed adding DRIVER_XE. Ensure both DRIVER_INTEL and DRIVER_XE
> are set to properly restrict the test to Intel GPUs.
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Kunal Joshi <kunal1.joshi@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> ---
>  tests/intel/kms_dp_link_training.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dp_link_training.c b/tests/intel/kms_dp_link_training.c
> index 7d3848b94..3df7b6562 100644
> --- a/tests/intel/kms_dp_link_training.c
> +++ b/tests/intel/kms_dp_link_training.c
> @@ -335,7 +335,7 @@ igt_main
>  	data_t data = {};
>  
>  	igt_fixture {
> -		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> +		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

>  		data.devid = intel_get_drm_devid(data.drm_fd);
>  		kmstest_set_vt_graphics_mode();
>  		igt_display_require(&data.display, data.drm_fd);
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE
  2025-03-06 15:25 [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE Marcin Bernatowicz
  2025-03-06 17:18 ` Kamil Konieczny
@ 2025-03-06 19:01 ` Kamil Konieczny
  2025-03-07  2:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Kamil Konieczny @ 2025-03-06 19:01 UTC (permalink / raw)
  To: Marcin Bernatowicz; +Cc: igt-dev, Kunal Joshi, Arun R Murthy

Hi Marcin,
On 2025-03-06 at 16:25:52 +0100, Marcin Bernatowicz wrote:
> Commit d7bccece44dd ("tests/intel/kms_dp_link_training: Restrict to Intel
> GPUs") missed adding DRIVER_XE. Ensure both DRIVER_INTEL and DRIVER_XE
> are set to properly restrict the test to Intel GPUs.
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Kunal Joshi <kunal1.joshi@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>

Applied, thank you.

Regards,
Kamil

> ---
>  tests/intel/kms_dp_link_training.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dp_link_training.c b/tests/intel/kms_dp_link_training.c
> index 7d3848b94..3df7b6562 100644
> --- a/tests/intel/kms_dp_link_training.c
> +++ b/tests/intel/kms_dp_link_training.c
> @@ -335,7 +335,7 @@ igt_main
>  	data_t data = {};
>  
>  	igt_fixture {
> -		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> +		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
>  		data.devid = intel_get_drm_devid(data.drm_fd);
>  		kmstest_set_vt_graphics_mode();
>  		igt_display_require(&data.display, data.drm_fd);
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* ✗ Fi.CI.BAT: failure for tests/intel/kms_dp_link_training: Add missing DRIVER_XE
  2025-03-06 15:25 [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE Marcin Bernatowicz
  2025-03-06 17:18 ` Kamil Konieczny
  2025-03-06 19:01 ` Kamil Konieczny
@ 2025-03-07  2:38 ` Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2025-03-07  2:38 UTC (permalink / raw)
  To: Marcin Bernatowicz; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

== Series Details ==

Series: tests/intel/kms_dp_link_training: Add missing DRIVER_XE
URL   : https://patchwork.freedesktop.org/series/145918/
State : failure

== Summary ==

Series 145918 revision 1 was fully merged or fully failed: no git log



[-- Attachment #2: Type: text/html, Size: 716 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-07  2:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06 15:25 [PATCH i-g-t] tests/intel/kms_dp_link_training: Add missing DRIVER_XE Marcin Bernatowicz
2025-03-06 17:18 ` Kamil Konieczny
2025-03-06 19:01 ` Kamil Konieczny
2025-03-07  2:38 ` ✗ Fi.CI.BAT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox