From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Lukasz Laguna <lukasz.laguna@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH v2 i-g-t 1/2] tests/intel/xe_drm_fdinfo: Check prerequisites for utilization subtests
Date: Thu, 6 Mar 2025 21:01:17 +0100 [thread overview]
Message-ID: <20250306200118.1771514-2-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20250306200118.1771514-1-marcin.bernatowicz@linux.intel.com>
Introduce require_engine_utilization_data() to verify utilization
data availability in each utilization subtest.
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Suggested-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/intel/xe_drm_fdinfo.c | 54 +++++++++++++++++++++++++++++--------
1 file changed, 43 insertions(+), 11 deletions(-)
diff --git a/tests/intel/xe_drm_fdinfo.c b/tests/intel/xe_drm_fdinfo.c
index f17245bea..f166b73d6 100644
--- a/tests/intel/xe_drm_fdinfo.c
+++ b/tests/intel/xe_drm_fdinfo.c
@@ -358,6 +358,16 @@ static void basic_memory(int xe)
}
}
+static void require_engine_utilization_data(int xe)
+{
+ struct drm_client_fdinfo info = {};
+
+ igt_require(igt_parse_drm_fdinfo(xe, &info, engine_map,
+ ARRAY_SIZE(engine_map), NULL, 0));
+ igt_require(info.num_engines);
+ igt_require(info.utilization_mask & DRM_FDINFO_UTILIZATION_CYCLES);
+}
+
static void basic_engine_utilization(int xe)
{
struct drm_client_fdinfo info = { };
@@ -736,8 +746,10 @@ igt_main
basic_memory(xe);
igt_describe("Check if basic fdinfo content is present for engine utilization");
- igt_subtest("basic-utilization")
+ igt_subtest("basic-utilization") {
+ require_engine_utilization_data(xe);
basic_engine_utilization(xe);
+ }
igt_describe("Create and compare total and resident memory consumption by client");
igt_subtest("mem-total-resident")
@@ -751,50 +763,69 @@ igt_main
igt_subtest("mem-active")
mem_active(xe, xe_engine(xe, 0));
- igt_subtest("utilization-single-idle")
+ igt_subtest("utilization-single-idle") {
+ require_engine_utilization_data(xe);
xe_for_each_engine(xe, hwe)
utilization_single(xe, hwe, 0);
+ }
- igt_subtest("utilization-single-full-load")
+ igt_subtest("utilization-single-full-load") {
+ require_engine_utilization_data(xe);
xe_for_each_engine(xe, hwe)
utilization_single(xe, hwe, TEST_BUSY | TEST_TRAILING_IDLE);
+ }
- igt_subtest("utilization-single-full-load-isolation")
+ igt_subtest("utilization-single-full-load-isolation") {
+ require_engine_utilization_data(xe);
xe_for_each_engine(xe, hwe)
utilization_single(xe, hwe, TEST_BUSY | TEST_TRAILING_IDLE | TEST_ISOLATION);
+ }
- igt_subtest("utilization-single-full-load-destroy-queue")
+ igt_subtest("utilization-single-full-load-destroy-queue") {
+ require_engine_utilization_data(xe);
xe_for_each_engine(xe, hwe)
utilization_single_destroy_queue(xe, hwe);
+ }
- igt_subtest("utilization-others-idle")
+ igt_subtest("utilization-others-idle") {
+ require_engine_utilization_data(xe);
xe_for_each_engine(xe, hwe)
utilization_others_idle(xe, hwe);
+ }
- igt_subtest("utilization-others-full-load")
+ igt_subtest("utilization-others-full-load") {
+ require_engine_utilization_data(xe);
xe_for_each_engine(xe, hwe)
utilization_others_full_load(xe, hwe);
+ }
- igt_subtest("utilization-all-full-load")
+ igt_subtest("utilization-all-full-load") {
+ require_engine_utilization_data(xe);
utilization_all_full_load(xe);
+ }
for (const struct section *s = sections; s->name; s++) {
- igt_subtest_f("%s-utilization-single-idle", s->name)
+ igt_subtest_f("%s-utilization-single-idle", s->name) {
+ require_engine_utilization_data(xe);
xe_for_each_gt(xe, gt)
xe_for_each_engine_class(class)
utilization_multi(xe, gt, class, s->flags);
+ }
- igt_subtest_f("%s-utilization-single-full-load", s->name)
+ igt_subtest_f("%s-utilization-single-full-load", s->name) {
+ require_engine_utilization_data(xe);
xe_for_each_gt(xe, gt)
xe_for_each_engine_class(class)
utilization_multi(xe, gt, class,
s->flags |
TEST_BUSY |
TEST_TRAILING_IDLE);
+ }
igt_subtest_f("%s-utilization-single-full-load-isolation",
- s->name)
+ s->name) {
+ require_engine_utilization_data(xe);
xe_for_each_gt(xe, gt)
xe_for_each_engine_class(class)
utilization_multi(xe, gt, class,
@@ -802,6 +833,7 @@ igt_main
TEST_BUSY |
TEST_TRAILING_IDLE |
TEST_ISOLATION);
+ }
}
igt_fixture {
--
2.31.1
next prev parent reply other threads:[~2025-03-06 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 20:01 [PATCH v2 i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests Marcin Bernatowicz
2025-03-06 20:01 ` Marcin Bernatowicz [this message]
2025-03-10 17:35 ` [PATCH v2 i-g-t 1/2] tests/intel/xe_drm_fdinfo: Check prerequisites for utilization subtests Kolakowski, Jakub1
2025-03-12 10:26 ` Kamil Konieczny
2025-03-06 20:01 ` [PATCH v2 i-g-t 2/2] tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization data Marcin Bernatowicz
2025-03-10 17:37 ` Kolakowski, Jakub1
2025-03-07 7:07 ` ✓ Xe.CI.BAT: success for tests/xe_drm_fdinfo: Check prerequisites for utilization tests (rev3) Patchwork
2025-03-07 7:21 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-07 20:59 ` ✗ Xe.CI.Full: " Patchwork
2025-03-12 10:44 ` Bernatowicz, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306200118.1771514-2-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox