From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
Jakub Kolakowski <jakub1.kolakowski@intel.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Lukasz Laguna <lukasz.laguna@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH v2 i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests
Date: Thu, 6 Mar 2025 21:01:16 +0100 [thread overview]
Message-ID: <20250306200118.1771514-1-marcin.bernatowicz@linux.intel.com> (raw)
This patch series ensures that utilization tests correctly check for
required utilization data before execution.
The first patch initially introduced an igt_subtest_group with a fixture
to verify utilization data availability. However, as pointed out by Kamil,
the fixture would still execute even if no test from the group was
selected, leading to potential log messages about unmet requirements when
running unrelated tests.
To address this, v2 introduces a helper function,
require_engine_utilization_data(), which is explicitly
called in each utilization-related subtest.
The second patch remains unchanged and replaces igt_require with
igt_assert in basic_engine_utilization, ensuring the test fails
explicitly when utilization data is missing.
V2:
- Dropped igt_subtest_group, as its fixture executed unconditionally.
- Introduced require_engine_utilization_data() helper to check
prerequisites in each subtest.
- Extended the requirement checks for the presence of engine utilization
cycles.
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Marcin Bernatowicz (2):
tests/intel/xe_drm_fdinfo: Check prerequisites for utilization
subtests
tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no
utilization data
tests/intel/xe_drm_fdinfo.c | 56 +++++++++++++++++++++++++++++--------
1 file changed, 44 insertions(+), 12 deletions(-)
--
2.31.1
next reply other threads:[~2025-03-06 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 20:01 Marcin Bernatowicz [this message]
2025-03-06 20:01 ` [PATCH v2 i-g-t 1/2] tests/intel/xe_drm_fdinfo: Check prerequisites for utilization subtests Marcin Bernatowicz
2025-03-10 17:35 ` Kolakowski, Jakub1
2025-03-12 10:26 ` Kamil Konieczny
2025-03-06 20:01 ` [PATCH v2 i-g-t 2/2] tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization data Marcin Bernatowicz
2025-03-10 17:37 ` Kolakowski, Jakub1
2025-03-07 7:07 ` ✓ Xe.CI.BAT: success for tests/xe_drm_fdinfo: Check prerequisites for utilization tests (rev3) Patchwork
2025-03-07 7:21 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-07 20:59 ` ✗ Xe.CI.Full: " Patchwork
2025-03-12 10:44 ` Bernatowicz, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306200118.1771514-1-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox