Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests
@ 2025-03-06 20:01 Marcin Bernatowicz
  2025-03-06 20:01 ` [PATCH v2 i-g-t 1/2] tests/intel/xe_drm_fdinfo: Check prerequisites for utilization subtests Marcin Bernatowicz
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Marcin Bernatowicz @ 2025-03-06 20:01 UTC (permalink / raw)
  To: igt-dev
  Cc: Marcin Bernatowicz, Jakub Kolakowski, Kamil Konieczny,
	Lucas De Marchi, Lukasz Laguna, Umesh Nerlige Ramappa

This patch series ensures that utilization tests correctly check for
required utilization data before execution.

The first patch initially introduced an igt_subtest_group with a fixture
to verify utilization data availability. However, as pointed out by Kamil,
the fixture would still execute even if no test from the group was
selected, leading to potential log messages about unmet requirements when
running unrelated tests.

To address this, v2 introduces a helper function,
require_engine_utilization_data(), which is explicitly
called in each utilization-related subtest.

The second patch remains unchanged and replaces igt_require with
igt_assert in basic_engine_utilization, ensuring the test fails
explicitly when utilization data is missing.

V2:
- Dropped igt_subtest_group, as its fixture executed unconditionally.
- Introduced require_engine_utilization_data() helper to check
  prerequisites in each subtest.
- Extended the requirement checks for the presence of engine utilization
  cycles.

Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Marcin Bernatowicz (2):
  tests/intel/xe_drm_fdinfo: Check prerequisites for utilization
    subtests
  tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no
    utilization data

 tests/intel/xe_drm_fdinfo.c | 56 +++++++++++++++++++++++++++++--------
 1 file changed, 44 insertions(+), 12 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-03-12 10:44 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06 20:01 [PATCH v2 i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests Marcin Bernatowicz
2025-03-06 20:01 ` [PATCH v2 i-g-t 1/2] tests/intel/xe_drm_fdinfo: Check prerequisites for utilization subtests Marcin Bernatowicz
2025-03-10 17:35   ` Kolakowski, Jakub1
2025-03-12 10:26   ` Kamil Konieczny
2025-03-06 20:01 ` [PATCH v2 i-g-t 2/2] tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization data Marcin Bernatowicz
2025-03-10 17:37   ` Kolakowski, Jakub1
2025-03-07  7:07 ` ✓ Xe.CI.BAT: success for tests/xe_drm_fdinfo: Check prerequisites for utilization tests (rev3) Patchwork
2025-03-07  7:21 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-07 20:59 ` ✗ Xe.CI.Full: " Patchwork
2025-03-12 10:44   ` Bernatowicz, Marcin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox