Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Sokolowski <jan.sokolowski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jan Sokolowski <jan.sokolowski@intel.com>,
	Katarzyna Piecielska <katarzyna.piecielska@intel.com>,
	Lukasz Laguna <lukasz.laguna@intel.com>,
	Christoph Manszewski <christoph.manszewski@intel.com>
Subject: [PATCH i-g-t v2 1/1] tests/intel/xe_exec_sip_eudebug: skip eudebug tests on VF
Date: Thu,  3 Apr 2025 11:53:07 +0000	[thread overview]
Message-ID: <20250403115307.232213-1-jan.sokolowski@intel.com> (raw)

Tests using eudebug are not compatible with VF functionality.
A way to check for that scenario is to check eudebug toggle
capability.

Skip a test that tries to use eudebug toggle if it doesn't
exist.

v2: Changed the idea from disabling a single test to disabling
all possible tests.

Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Cc: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Reviewed-by: Christoph Manszewski <christoph.manszewski@intel.com>
Cc: Christoph Manszewski <christoph.manszewski@intel.com>
---
 lib/xe/xe_eudebug.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/xe/xe_eudebug.c b/lib/xe/xe_eudebug.c
index ec946058b..667c31c6e 100644
--- a/lib/xe/xe_eudebug.c
+++ b/lib/xe/xe_eudebug.c
@@ -1794,10 +1794,7 @@ bool xe_eudebug_enable(int fd, bool enable)
 	bool old = false;
 	int ret = __xe_eudebug_enable_getset(fd, &old, &enable);
 
-	if (ret) {
-		igt_skip_on(enable);
-		old = false;
-	}
+	igt_skip_on(ret);
 
 	return old;
 }
-- 
2.34.1


             reply	other threads:[~2025-04-03 11:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 11:53 Jan Sokolowski [this message]
2025-04-03 18:59 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,v2,1/1] tests/intel/xe_exec_sip_eudebug: skip eudebug tests on VF Patchwork
2025-04-03 20:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-03 22:47 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-04  1:56 ` ✗ Xe.CI.Full: " Patchwork
2025-04-09  9:08 ` [PATCH i-g-t v2 1/1] " Manszewski, Christoph
2025-04-09 10:41   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250403115307.232213-1-jan.sokolowski@intel.com \
    --to=jan.sokolowski@intel.com \
    --cc=christoph.manszewski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=katarzyna.piecielska@intel.com \
    --cc=lukasz.laguna@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox